Review feedback. Use TELEMETRY_TYPE constant and set to APP_ID

elastic · Jun 23, 2020 · 6484570 · 6484570
1 parent 6f5a281
commit 6484570
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/x-pack/plugins/maps/common/constants.ts b/x-pack/plugins/maps/common/constants.ts
@@ -25,7 +25,7 @@ export const EMS_TILES_VECTOR_TILE_PATH = 'vector/tile';
 export const MAP_SAVED_OBJECT_TYPE = 'map';
 export const APP_ID = 'maps';
 export const APP_ICON = 'gisApp';
-export const TELEMETRY_TYPE = 'maps-telemetry';
+export const TELEMETRY_TYPE = APP_ID;
 
 export const MAP_APP_PATH = `app/${APP_ID}`;
 export const GIS_API_PATH = `api/${APP_ID}`;

diff --git a/x-pack/plugins/maps/server/maps_telemetry/collectors/register.ts b/x-pack/plugins/maps/server/maps_telemetry/collectors/register.ts
@@ -7,7 +7,7 @@
 import { UsageCollectionSetup } from 'src/plugins/usage_collection/server';
 import { getMapsTelemetry } from '../maps_telemetry';
 // @ts-ignore
-import { APP_ID } from '../../../common/constants';
+import { TELEMETRY_TYPE } from '../../../common/constants';
 import { MapsConfigType } from '../../../config';
 
 export function registerMapsUsageCollector(
@@ -19,7 +19,7 @@ export function registerMapsUsageCollector(
   }
 
   const mapsUsageCollector = usageCollection.makeUsageCollector({
-    type: APP_ID,
+    type: TELEMETRY_TYPE,
     isReady: () => true,
     fetch: async () => await getMapsTelemetry(config),
   });