changes based on review

elastic · Sep 11, 2019 · 5860819 · 5860819
1 parent 5894836
commit 5860819
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/x-pack/legacy/plugins/ml/public/jobs/new_job_new/common/job_validator/job_validator.ts b/x-pack/legacy/plugins/ml/public/jobs/new_job_new/common/job_validator/job_validator.ts
@@ -37,7 +37,7 @@ export class JobValidator {
   private _jobCreator: JobCreatorType;
   private _validationSummary: ValidationSummary;
   private _lastJobConfig: string;
-  private _validateTimeout: NodeJS.Timeout | null = null;
+  private _validateTimeout: ReturnType<typeof setTimeout> | null = null;
   private _existingJobsAndGroups: ExistingJobsAndGroups;
   private _basicValidations: BasicValidations = {
     jobId: { valid: true },

diff --git a/x-pack/legacy/plugins/ml/public/jobs/new_job_new/pages/new_job/wizard.tsx b/x-pack/legacy/plugins/ml/public/jobs/new_job_new/pages/new_job/wizard.tsx
@@ -86,7 +86,6 @@ export const Wizard: FC<Props> = ({
   );
 
   useEffect(() => {
-    // IIFE to run the validation. the useEffect callback can't be async
     jobValidator.validate(() => {
       setJobValidatorUpdate(jobValidatorUpdated);
     });