Skip to content

Commit

Permalink
Propagate prebuiltRulesFrom{FileSystem,SavedObjects} from configs
Browse files Browse the repository at this point in the history
  • Loading branch information
rw-access committed Jul 20, 2021
1 parent 91d87c9 commit 4ddc48a
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,8 @@ export class EndpointAppContextService {
this.manifestManager,
dependencies.appClientFactory,
dependencies.config.maxTimelineImportExportSize,
dependencies.config.prebuiltRulesFromFileSystem,
dependencies.config.prebuiltRulesFromSavedObjects,
dependencies.security,
dependencies.alerting,
dependencies.licenseService,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ describe('ingest_integration tests ', () => {
let ctx: SecuritySolutionRequestHandlerContext;
const exceptionListClient: ExceptionListClient = getExceptionListClientMock();
const maxTimelineImportExportSize = createMockConfig().maxTimelineImportExportSize;
const prebuiltRulesFromFileSystem = createMockConfig().prebuiltRulesFromFileSystem;
const prebuiltRulesFromSavedObjects = createMockConfig().prebuiltRulesFromSavedObjects;
let licenseEmitter: Subject<ILicense>;
let licenseService: LicenseService;
const Platinum = licenseMock.createLicense({ license: { type: 'platinum', mode: 'platinum' } });
Expand Down Expand Up @@ -80,6 +82,8 @@ describe('ingest_integration tests ', () => {
manifestManager,
endpointAppContextMock.appClientFactory,
maxTimelineImportExportSize,
prebuiltRulesFromFileSystem,
prebuiltRulesFromSavedObjects,
endpointAppContextMock.security,
endpointAppContextMock.alerting,
licenseService,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ export const getPackagePolicyCreateCallback = (
manifestManager: ManifestManager,
appClientFactory: AppClientFactory,
maxTimelineImportExportSize: number,
prebuiltRulesFromFileSystem: boolean,
prebuiltRulesFromSavedObjects: boolean,
securityStart: SecurityPluginStart,
alerts: AlertsStartContract,
licenseService: LicenseService,
Expand Down Expand Up @@ -61,6 +63,8 @@ export const getPackagePolicyCreateCallback = (
securityStart,
alerts,
maxTimelineImportExportSize,
prebuiltRulesFromFileSystem,
prebuiltRulesFromSavedObjects,
exceptionsClient,
}),

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ export interface InstallPrepackagedRulesProps {
securityStart: SecurityPluginStart;
alerts: AlertsStartContract;
maxTimelineImportExportSize: number;
prebuiltRulesFromFileSystem: boolean;
prebuiltRulesFromSavedObjects: boolean;
exceptionsClient: ExceptionListClient;
}

Expand All @@ -37,6 +39,8 @@ export const installPrepackagedRules = async ({
securityStart,
alerts,
maxTimelineImportExportSize,
prebuiltRulesFromFileSystem,
prebuiltRulesFromSavedObjects,
exceptionsClient,
}: InstallPrepackagedRulesProps): Promise<void> => {
// prep for detection rules creation
Expand Down Expand Up @@ -70,8 +74,8 @@ export const installPrepackagedRules = async ({
alerts.getAlertsClientWithRequest(request),
frameworkRequest,
maxTimelineImportExportSize,
/* prebuiltRulesFromFileSystem: */ true,
/* prebuiltRulesFromSavedObjects: */ false,
prebuiltRulesFromFileSystem,
prebuiltRulesFromSavedObjects,
exceptionsClient
);
} catch (err) {
Expand Down

0 comments on commit 4ddc48a

Please sign in to comment.