Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
cnasikas committed Nov 14, 2023
1 parent b31c167 commit 462ce47
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ describe('CasesConnector', () => {
});
});

it('does not creates when there are no 404 errors', async () => {
it('does not create when there are no 404 errors', async () => {
casesClientMock.cases.bulkGet.mockResolvedValue({
cases: [cases[0], cases[1]],
errors: [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,10 @@ export class CasesConnector extends SubActionConnector<
const tags = Array.isArray(params.rule.tags) ? params.rule.tags : [];

/**
* TODO: Add grouping info to
* TODO:
* 1. Add grouping info to
* 2. Required custom fields will throw an error when creating a case.
* We should find a way to fill the custom fields with default values.
*/
return {
description,
Expand Down

0 comments on commit 462ce47

Please sign in to comment.