-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
) * Set up navigateToUrl context * Update RR link helpers to use navigateToUrl * Update breadcrumbs to use navigateToUrl + refactor generate_breadcrumbs: - Change base breadcrumb generator to a custom React useHook instead of passing history/context around - Change use{Product}Breadcrumbs helpers to mainly involve merging arrays - Update + simplify tests accordingly (test link behavior in main useBreadcrumb suite, not in subsequent helpers) set_chrome: - Update to use new breadcrumb hooks (requires pulling out of useEffect, hooks can't be used inside another hook) - Clean up/refactor tests * Update route redirects now that navigation works correctly
- Loading branch information
Constance
authored
Aug 20, 2020
1 parent
fc526d8
commit 3dcec1c
Showing
10 changed files
with
209 additions
and
260 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.