Skip to content

Commit

Permalink
[8.9] [Security Solution] adds missing dependency fieldFormats in k…
Browse files Browse the repository at this point in the history
…ibana.jsonc (#160445) (#160464)

# Backport

This will backport the following commits from `main` to `8.9`:
- [[Security Solution] adds missing dependency `fieldFormats` in
kibana.jsonc (#160445)](#160445)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Devin W.
Hurley","email":"devin.hurley@elastic.co"},"sourceCommit":{"committedDate":"2023-06-23T21:14:17Z","message":"[Security
Solution] adds missing dependency `fieldFormats` in kibana.jsonc
(#160445)\n\n## Summary\r\n\r\nAdds missing dependency from this
PR:\r\nhttps://github.com//pull/158594","sha":"1ee60b0ba85409aaca28d65dc70956b082e66a7a","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","release_note:skip","v8.9.0","v8.10.0"],"number":160445,"url":"https://github.com/elastic/kibana/pull/160445","mergeCommit":{"message":"[Security
Solution] adds missing dependency `fieldFormats` in kibana.jsonc
(#160445)\n\n## Summary\r\n\r\nAdds missing dependency from this
PR:\r\nhttps://github.com//pull/158594","sha":"1ee60b0ba85409aaca28d65dc70956b082e66a7a"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160445","number":160445,"mergeCommit":{"message":"[Security
Solution] adds missing dependency `fieldFormats` in kibana.jsonc
(#160445)\n\n## Summary\r\n\r\nAdds missing dependency from this
PR:\r\nhttps://github.com//pull/158594","sha":"1ee60b0ba85409aaca28d65dc70956b082e66a7a"}}]}]
BACKPORT-->

Co-authored-by: Devin W. Hurley <devin.hurley@elastic.co>
  • Loading branch information
kibanamachine and dhurley14 authored Jun 23, 2023
1 parent 34b6188 commit 3d73573
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 8 deletions.
12 changes: 4 additions & 8 deletions x-pack/plugins/security_solution/kibana.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,7 @@
"id": "securitySolution",
"server": true,
"browser": true,
"configPath": [
"xpack",
"securitySolution"
],
"configPath": ["xpack", "securitySolution"],
"requiredPlugins": [
"actions",
"alerting",
Expand All @@ -24,6 +21,7 @@
"embeddable",
"eventLog",
"features",
"fieldFormats",
"guidedOnboarding",
"inspector",
"kubernetesSecurity",
Expand All @@ -43,7 +41,7 @@
"controls",
"dataViews",
"savedObjectsManagement",
"stackConnectors",
"stackConnectors"
],
"optionalPlugins": [
"cloudExperiments",
Expand Down Expand Up @@ -71,8 +69,6 @@
"unifiedSearch",
"cloudChat"
],
"extraPublicDirs": [
"common"
]
"extraPublicDirs": ["common"]
}
}
9 changes: 9 additions & 0 deletions x-pack/plugins/security_solution/public/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,15 @@ export interface SetupPlugins {
ml?: MlPluginSetup;
}

/**
* IMPORTANT - PLEASE READ: When adding new plugins to the
* security solution, please ensure you add that plugin
* name to the kibana.jsonc file located in ../kibana.jsonc
*
* Without adding the plugin name there, the plugin will not
* fulfill at runtime, despite the types showing up correctly
* in the code.
*/
export interface StartPlugins {
cases: CasesUiStart;
data: DataPublicPluginStart;
Expand Down

0 comments on commit 3d73573

Please sign in to comment.