fix PR comments

src/plugins/data/public/search/search_source/search_source.ts

@@ -110,7 +110,7 @@ export class SearchSource {
   }
 
   /** ***
-   * PUBLIC APIgetInternalStartServices
+   * PUBLIC API
    *****/
 
   setPreferredSearchStrategyId(searchStrategyId: string) {

src/plugins/saved_objects_management/public/lib/resolve_saved_objects.test.ts

@@ -234,12 +234,15 @@ describe('resolveSavedObjects', () => {
   });
 
   describe('resolveIndexPatternConflicts', () => {
-    let dependencies: Parameters<typeof resolveIndexPatternConflicts>[4];
+    let dependencies: Parameters<typeof resolveIndexPatternConflicts>[3];
 
     beforeEach(() => {
       const search = dataPluginMock.createStartContract().search;
 
       dependencies = {
+        indexPatterns: ({
+          get: (id: string) => Promise.resolve({ id }),
+        } as unknown) as IndexPatternsContract,
         search,
       };
     });
@@ -299,9 +302,6 @@ describe('resolveSavedObjects', () => {
         resolutions,
         conflictedIndexPatterns,
         overwriteAll,
-        ({
-          get: (id: string) => Promise.resolve({ id }),
-        } as unknown) as IndexPatternsContract,
         dependencies
       );
 
@@ -365,9 +365,6 @@ describe('resolveSavedObjects', () => {
         resolutions,
         conflictedIndexPatterns,
         overwriteAll,
-        ({
-          get: (id: string) => Promise.resolve({ id }),
-        } as unknown) as IndexPatternsContract,
         dependencies
       );
 

src/plugins/saved_objects_management/public/lib/resolve_saved_objects.ts

@@ -162,8 +162,8 @@ export async function resolveIndexPatternConflicts(
   resolutions: Array<{ oldId: string; newId: string }>,
   conflictedIndexPatterns: any[],
   overwriteAll: boolean,
-  indexPatterns: IndexPatternsContract,
   dependencies: {
+    indexPatterns: IndexPatternsContract;
     search: DataPublicPluginStart['search'];
   }
 ) {

src/plugins/saved_objects_management/public/management_section/objects_table/components/flyout.test.tsx

@@ -502,9 +502,9 @@ describe('Flyout', () => {
         component.instance().resolutions,
         mockConflictedIndexPatterns,
         true,
-        defaultProps.indexPatterns,
         {
           search: defaultProps.search,
+          indexPatterns: defaultProps.indexPatterns,
         }
       );
       expect(saveObjectsMock).toHaveBeenCalledWith(

src/plugins/saved_objects_management/public/management_section/objects_table/components/flyout.tsx

@@ -393,8 +393,8 @@ export class Flyout extends Component<FlyoutProps, FlyoutState> {
             resolutions,
             conflictedIndexPatterns!,
             isOverwriteAllChecked,
-            indexPatterns,
             {
+              indexPatterns,
               search,
             }
           );