De-angularize vis tooltips (#54954) (#55432)

* Remove angular dependencey from vis/tooltip * Move tooltip logic into vislib * Remove and fix all ngMock refs in vislib tests * Add numeral to renovate config * Add vis_type_vislib to codeowners * Move vis_legend into vislib and fix errors * vis_type_vislib/public imports to be only top-level
elastic · Jan 21, 2020 · 2fcac07 · 2fcac07
1 parent 0c62eba
commit 2fcac07
Show file tree

Hide file tree

Showing 123 changed files with 1,414 additions and 1,707 deletions.
diff --git a/.i18nrc.json b/.i18nrc.json
@@ -21,7 +21,6 @@
     "interpreter": "src/legacy/core_plugins/interpreter",
     "kbn": "src/legacy/core_plugins/kibana",
     "kbnDocViews": "src/legacy/core_plugins/kbn_doc_views",
-    "kbnVislibVisTypes": "src/legacy/core_plugins/vis_type_vislib",
     "management": ["src/legacy/core_plugins/management", "src/plugins/management"],
     "kibana_react": "src/legacy/core_plugins/kibana_react",
     "kibana-react": "src/plugins/kibana_react",
@@ -41,6 +40,7 @@
     "visTypeTagCloud": "src/legacy/core_plugins/vis_type_tagcloud",
     "visTypeTimeseries": "src/legacy/core_plugins/vis_type_timeseries",
     "visTypeVega": "src/legacy/core_plugins/vis_type_vega",
+    "visTypeVislib": "src/legacy/core_plugins/vis_type_vislib",
     "visualizations": [
       "src/plugins/visualizations",
       "src/legacy/core_plugins/visualizations"
@@ -50,4 +50,4 @@
     "src/legacy/ui/ui_render/ui_render_mixin.js"
   ],
   "translations": []
-}
+}
diff --git a/package.json b/package.json
@@ -343,6 +343,7 @@
     "@types/moment-timezone": "^0.5.12",
     "@types/mustache": "^0.8.31",
     "@types/node": "^10.12.27",
+    "@types/numeral": "^0.0.26",
     "@types/opn": "^5.1.0",
     "@types/pegjs": "^0.10.1",
     "@types/pngjs": "^3.3.2",

diff --git a/renovate.json5 b/renovate.json5
@@ -740,6 +740,14 @@
           '@types/memoize-one',
         ],
       },
+      {
+        groupSlug: 'numeral',
+        groupName: 'numeral related packages',
+        packageNames: [
+          'numeral',
+          '@types/numeral',
+        ],
+      },
       {
         groupSlug: 'mime',
         groupName: 'mime related packages',

diff --git a/src/legacy/core_plugins/region_map/public/components/region_map_options.tsx b/src/legacy/core_plugins/region_map/public/components/region_map_options.tsx
@@ -24,11 +24,7 @@ import { FormattedMessage } from '@kbn/i18n/react';
 
 import { FileLayerField, VectorLayer, ServiceSettings } from 'ui/vis/map/service_settings';
 import { VisOptionsProps } from 'ui/vis/editors/default';
-import {
-  NumberInputOption,
-  SelectOption,
-  SwitchOption,
-} from '../../../vis_type_vislib/public/components';
+import { NumberInputOption, SelectOption, SwitchOption } from '../../../vis_type_vislib/public';
 import { WmsOptions } from '../../../tile_map/public/components/wms_options';
 import { RegionMapVisParams } from '../types';
 

diff --git a/src/legacy/core_plugins/tile_map/public/components/tile_map_options.tsx b/src/legacy/core_plugins/tile_map/public/components/tile_map_options.tsx
@@ -27,7 +27,7 @@ import {
   RangeOption,
   SelectOption,
   SwitchOption,
-} from '../../../vis_type_vislib/public/components';
+} from '../../../vis_type_vislib/public';
 import { WmsOptions } from './wms_options';
 import { TileMapVisParams } from '../types';
 import { MapTypes } from '../map_types';

diff --git a/src/legacy/core_plugins/tile_map/public/components/wms_internal_options.tsx b/src/legacy/core_plugins/tile_map/public/components/wms_internal_options.tsx
@@ -21,7 +21,7 @@ import React from 'react';
 import { EuiLink, EuiSpacer, EuiText, EuiScreenReaderOnly } from '@elastic/eui';
 import { FormattedMessage } from '@kbn/i18n/react';
 
-import { TextInputOption } from '../../../vis_type_vislib/public/components';
+import { TextInputOption } from '../../../vis_type_vislib/public';
 import { WMSOptions } from '../types';
 
 interface WmsInternalOptions {

diff --git a/src/legacy/core_plugins/tile_map/public/components/wms_options.tsx b/src/legacy/core_plugins/tile_map/public/components/wms_options.tsx
@@ -25,7 +25,7 @@ import { FormattedMessage } from '@kbn/i18n/react';
 import { TmsLayer } from 'ui/vis/map/service_settings';
 import { Vis } from 'ui/vis';
 import { RegionMapVisParams } from '../../../region_map/public/types';
-import { SelectOption, SwitchOption } from '../../../vis_type_vislib/public/components';
+import { SelectOption, SwitchOption } from '../../../vis_type_vislib/public';
 import { WmsInternalOptions } from './wms_internal_options';
 import { WMSOptions, TileMapVisParams } from '../types';
 

diff --git a/src/legacy/core_plugins/vis_type_markdown/public/settings_options.tsx b/src/legacy/core_plugins/vis_type_markdown/public/settings_options.tsx
@@ -22,7 +22,7 @@ import { EuiPanel } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
 
 import { VisOptionsProps } from 'ui/vis/editors/default';
-import { RangeOption, SwitchOption } from '../../vis_type_vislib/public/components';
+import { RangeOption, SwitchOption } from '../../vis_type_vislib/public';
 import { MarkdownVisParams } from './types';
 
 function SettingsOptions({ stateParams, setValue }: VisOptionsProps<MarkdownVisParams>) {

diff --git a/src/legacy/core_plugins/vis_type_metric/public/components/metric_vis_options.tsx b/src/legacy/core_plugins/vis_type_metric/public/components/metric_vis_options.tsx
@@ -31,13 +31,13 @@ import { FormattedMessage } from '@kbn/i18n/react';
 
 import { VisOptionsProps } from '../legacy_imports';
 import {
+  ColorModes,
   ColorRanges,
   ColorSchemaOptions,
   SwitchOption,
   RangeOption,
   SetColorSchemaOptionsValue,
-} from '../../../vis_type_vislib/public/components';
-import { ColorModes } from '../../../vis_type_vislib/public/utils/collections';
+} from '../../../vis_type_vislib/public';
 import { MetricVisParam, VisParams } from '../types';
 import { SetColorRangeValue } from '../../../vis_type_vislib/public/components/common/color_ranges';
 

diff --git a/src/legacy/core_plugins/vis_type_metric/public/metric_vis_fn.ts b/src/legacy/core_plugins/vis_type_metric/public/metric_vis_fn.ts
@@ -27,7 +27,7 @@ import {
   Render,
   Style,
 } from '../../../../plugins/expressions/public';
-import { ColorModes } from '../../vis_type_vislib/public/utils/collections';
+import { ColorModes } from '../../vis_type_vislib/public';
 import { visType, DimensionsVisParam, VisParams } from './types';
 
 export type Context = KibanaDatatable;

diff --git a/src/legacy/core_plugins/vis_type_metric/public/metric_vis_type.ts b/src/legacy/core_plugins/vis_type_metric/public/metric_vis_type.ts
@@ -21,8 +21,8 @@ import { i18n } from '@kbn/i18n';
 
 import { MetricVisComponent } from './components/metric_vis_component';
 import { MetricVisOptions } from './components/metric_vis_options';
+import { ColorModes } from '../../vis_type_vislib/public';
 import { Schemas, AggGroupNames, colorSchemas, ColorSchemas } from './legacy_imports';
-import { ColorModes } from '../../vis_type_vislib/public/utils/collections';
 
 export const metricVisTypeDefinition = {
   name: 'metric',

diff --git a/src/legacy/core_plugins/vis_type_metric/public/types.ts b/src/legacy/core_plugins/vis_type_metric/public/types.ts
@@ -20,8 +20,7 @@
 import { ColorSchemas } from './legacy_imports';
 import { Range } from '../../../../plugins/expressions/public';
 import { SchemaConfig } from '../../visualizations/public';
-import { ColorModes } from '../../vis_type_vislib/public/utils/collections';
-import { Labels, Style } from '../../vis_type_vislib/public/types';
+import { ColorModes, Labels, Style } from '../../vis_type_vislib/public';
 
 export const visType = 'metric';
 

diff --git a/src/legacy/core_plugins/vis_type_table/public/components/table_vis_options.tsx b/src/legacy/core_plugins/vis_type_table/public/components/table_vis_options.tsx
@@ -24,11 +24,7 @@ import { i18n } from '@kbn/i18n';
 import { FormattedMessage } from '@kbn/i18n/react';
 
 import { tabifyGetColumns, VisOptionsProps } from '../legacy_imports';
-import {
-  NumberInputOption,
-  SwitchOption,
-  SelectOption,
-} from '../../../vis_type_vislib/public/components/common';
+import { NumberInputOption, SwitchOption, SelectOption } from '../../../vis_type_vislib/public';
 import { TableVisParams } from '../types';
 import { totalAggregations, isAggConfigNumeric } from './utils';
 

diff --git a/src/legacy/core_plugins/vis_type_tagcloud/public/components/tag_cloud_options.tsx b/src/legacy/core_plugins/vis_type_tagcloud/public/components/tag_cloud_options.tsx
@@ -23,7 +23,7 @@ import { i18n } from '@kbn/i18n';
 
 import { ValidatedDualRange } from 'ui/validated_range';
 import { VisOptionsProps } from 'ui/vis/editors/default';
-import { SelectOption, SwitchOption } from '../../../vis_type_vislib/public/components';
+import { SelectOption, SwitchOption } from '../../../vis_type_vislib/public';
 import { TagCloudVisParams } from '../types';
 
 function TagCloudOptions({ stateParams, setValue, vis }: VisOptionsProps<TagCloudVisParams>) {

diff --git a/src/legacy/core_plugins/vis_type_vislib/public/area.ts b/src/legacy/core_plugins/vis_type_vislib/public/area.ts
@@ -42,9 +42,9 @@ import { KbnVislibVisTypesDependencies } from './plugin';
 
 export const createAreaVisTypeDefinition = (deps: KbnVislibVisTypesDependencies) => ({
   name: 'area',
-  title: i18n.translate('kbnVislibVisTypes.area.areaTitle', { defaultMessage: 'Area' }),
+  title: i18n.translate('visTypeVislib.area.areaTitle', { defaultMessage: 'Area' }),
   icon: 'visArea',
-  description: i18n.translate('kbnVislibVisTypes.area.areaDescription', {
+  description: i18n.translate('visTypeVislib.area.areaDescription', {
     defaultMessage: 'Emphasize the quantity beneath a line chart',
   }),
   visualization: createVislibVisController(deps),
@@ -136,7 +136,7 @@ export const createAreaVisTypeDefinition = (deps: KbnVislibVisTypesDependencies)
       {
         group: AggGroupNames.Metrics,
         name: 'metric',
-        title: i18n.translate('kbnVislibVisTypes.area.metricsTitle', {
+        title: i18n.translate('visTypeVislib.area.metricsTitle', {
           defaultMessage: 'Y-axis',
         }),
         aggFilter: ['!geo_centroid', '!geo_bounds'],
@@ -146,7 +146,7 @@ export const createAreaVisTypeDefinition = (deps: KbnVislibVisTypesDependencies)
       {
         group: AggGroupNames.Metrics,
         name: 'radius',
-        title: i18n.translate('kbnVislibVisTypes.area.radiusTitle', {
+        title: i18n.translate('visTypeVislib.area.radiusTitle', {
           defaultMessage: 'Dot size',
         }),
         min: 0,
@@ -156,7 +156,7 @@ export const createAreaVisTypeDefinition = (deps: KbnVislibVisTypesDependencies)
       {
         group: AggGroupNames.Buckets,
         name: 'segment',
-        title: i18n.translate('kbnVislibVisTypes.area.segmentTitle', {
+        title: i18n.translate('visTypeVislib.area.segmentTitle', {
           defaultMessage: 'X-axis',
         }),
         min: 0,
@@ -166,7 +166,7 @@ export const createAreaVisTypeDefinition = (deps: KbnVislibVisTypesDependencies)
       {
         group: AggGroupNames.Buckets,
         name: 'group',
-        title: i18n.translate('kbnVislibVisTypes.area.groupTitle', {
+        title: i18n.translate('visTypeVislib.area.groupTitle', {
           defaultMessage: 'Split series',
         }),
         min: 0,
@@ -176,7 +176,7 @@ export const createAreaVisTypeDefinition = (deps: KbnVislibVisTypesDependencies)
       {
         group: AggGroupNames.Buckets,
         name: 'split',
-        title: i18n.translate('kbnVislibVisTypes.area.splitTitle', {
+        title: i18n.translate('visTypeVislib.area.splitTitle', {
           defaultMessage: 'Split chart',
         }),
         min: 0,

diff --git a/src/legacy/core_plugins/vis_type_vislib/public/components/common/basic_options.tsx b/src/legacy/core_plugins/vis_type_vislib/public/components/common/basic_options.tsx
@@ -37,7 +37,7 @@ function BasicOptions<VisParams extends BasicOptionsParams>({
   return (
     <>
       <SelectOption
-        label={i18n.translate('kbnVislibVisTypes.controls.vislibBasicOptions.legendPositionLabel', {
+        label={i18n.translate('visTypeVislib.controls.vislibBasicOptions.legendPositionLabel', {
           defaultMessage: 'Legend position',
         })}
         options={vis.type.editorConfig.collections.legendPositions}
@@ -46,7 +46,7 @@ function BasicOptions<VisParams extends BasicOptionsParams>({
         setValue={setValue}
       />
       <SwitchOption
-        label={i18n.translate('kbnVislibVisTypes.controls.vislibBasicOptions.showTooltipLabel', {
+        label={i18n.translate('visTypeVislib.controls.vislibBasicOptions.showTooltipLabel', {
           defaultMessage: 'Show tooltip',
         })}
         paramName="addTooltip"

diff --git a/src/legacy/core_plugins/vis_type_vislib/public/components/common/color_ranges.tsx b/src/legacy/core_plugins/vis_type_vislib/public/components/common/color_ranges.tsx
@@ -71,7 +71,7 @@ function ColorRanges({
   return (
     <RangesParamEditor
       data-test-subj={dataTestSubj}
-      error={i18n.translate('kbnVislibVisTypes.controls.colorRanges.errorText', {
+      error={i18n.translate('visTypeVislib.controls.colorRanges.errorText', {
         defaultMessage: 'Each range should be greater than previous.',
       })}
       hidePlaceholders={true}

diff --git a/src/legacy/core_plugins/vis_type_vislib/public/components/common/color_schema.tsx b/src/legacy/core_plugins/vis_type_vislib/public/components/common/color_schema.tsx
@@ -66,7 +66,7 @@ function ColorSchemaOptions({
         }}
       >
         <FormattedMessage
-          id="kbnVislibVisTypes.controls.colorSchema.resetColorsButtonLabel"
+          id="visTypeVislib.controls.colorSchema.resetColorsButtonLabel"
           defaultMessage="Reset colors"
         />
       </EuiLink>
@@ -79,11 +79,11 @@ function ColorSchemaOptions({
         disabled={disabled}
         helpText={
           showHelpText &&
-          i18n.translate('kbnVislibVisTypes.controls.colorSchema.howToChangeColorsDescription', {
+          i18n.translate('visTypeVislib.controls.colorSchema.howToChangeColorsDescription', {
             defaultMessage: 'Individual colors can be changed in the legend.',
           })
         }
-        label={i18n.translate('kbnVislibVisTypes.controls.colorSchema.colorSchemaLabel', {
+        label={i18n.translate('visTypeVislib.controls.colorSchema.colorSchemaLabel', {
           defaultMessage: 'Color schema',
         })}
         labelAppend={isCustomColors && resetColorsButton}
@@ -95,7 +95,7 @@ function ColorSchemaOptions({
 
       <SwitchOption
         disabled={disabled}
-        label={i18n.translate('kbnVislibVisTypes.controls.colorSchema.reverseColorSchemaLabel', {
+        label={i18n.translate('visTypeVislib.controls.colorSchema.reverseColorSchemaLabel', {
           defaultMessage: 'Reverse schema',
         })}
         paramName="invertColors"

diff --git a/src/legacy/core_plugins/vis_type_vislib/public/components/common/range.tsx b/src/legacy/core_plugins/vis_type_vislib/public/components/common/range.tsx
@@ -49,7 +49,7 @@ function RangeOption<ParamName extends string>({
   const [stateValue, setStateValue] = useState(value);
   const [isValidState, setIsValidState] = useState(true);
 
-  const error = i18n.translate('kbnVislibVisTypes.controls.rangeErrorMessage', {
+  const error = i18n.translate('visTypeVislib.controls.rangeErrorMessage', {
     defaultMessage: 'Values must be on or between {min} and {max}',
     values: { min, max },
   });

diff --git a/src/legacy/core_plugins/vis_type_vislib/public/components/common/truncate_labels.tsx b/src/legacy/core_plugins/vis_type_vislib/public/components/common/truncate_labels.tsx
@@ -33,7 +33,7 @@ function TruncateLabelsOption({ disabled, value = null, setValue }: TruncateLabe
 
   return (
     <EuiFormRow
-      label={i18n.translate('kbnVislibVisTypes.controls.truncateLabel', {
+      label={i18n.translate('visTypeVislib.controls.truncateLabel', {
         defaultMessage: 'Truncate',
       })}
       fullWidth

diff --git a/src/legacy/core_plugins/vis_type_vislib/public/components/options/gauge/labels_panel.tsx b/src/legacy/core_plugins/vis_type_vislib/public/components/options/gauge/labels_panel.tsx
@@ -31,15 +31,15 @@ function LabelsPanel({ stateParams, setValue, setGaugeValue }: GaugeOptionsInter
       <EuiTitle size="xs">
         <h3>
           <FormattedMessage
-            id="kbnVislibVisTypes.controls.gaugeOptions.labelsTitle"
+            id="visTypeVislib.controls.gaugeOptions.labelsTitle"
             defaultMessage="Labels"
           />
         </h3>
       </EuiTitle>
       <EuiSpacer size="s" />
 
       <SwitchOption
-        label={i18n.translate('kbnVislibVisTypes.controls.gaugeOptions.showLabelsLabel', {
+        label={i18n.translate('visTypeVislib.controls.gaugeOptions.showLabelsLabel', {
           defaultMessage: 'Show labels',
         })}
         paramName="show"
@@ -52,7 +52,7 @@ function LabelsPanel({ stateParams, setValue, setGaugeValue }: GaugeOptionsInter
 
       <TextInputOption
         disabled={!stateParams.gauge.labels.show}
-        label={i18n.translate('kbnVislibVisTypes.controls.gaugeOptions.subTextLabel', {
+        label={i18n.translate('visTypeVislib.controls.gaugeOptions.subTextLabel', {
           defaultMessage: 'Sub label',
         })}
         paramName="subText"
@@ -64,10 +64,10 @@ function LabelsPanel({ stateParams, setValue, setGaugeValue }: GaugeOptionsInter
 
       <SwitchOption
         disabled={!stateParams.gauge.labels.show}
-        label={i18n.translate('kbnVislibVisTypes.controls.gaugeOptions.displayWarningsLabel', {
+        label={i18n.translate('visTypeVislib.controls.gaugeOptions.displayWarningsLabel', {
           defaultMessage: 'Display warnings',
         })}
-        tooltip={i18n.translate('kbnVislibVisTypes.controls.gaugeOptions.switchWarningsTooltip', {
+        tooltip={i18n.translate('visTypeVislib.controls.gaugeOptions.switchWarningsTooltip', {
           defaultMessage:
             'Turns on/off warnings. When turned on, a warning will be shown if not all labels could be displayed.',
         })}

diff --git a/src/legacy/core_plugins/vis_type_vislib/public/components/options/gauge/ranges_panel.tsx b/src/legacy/core_plugins/vis_type_vislib/public/components/options/gauge/ranges_panel.tsx
@@ -59,7 +59,7 @@ function RangesPanel({
       <EuiTitle size="xs">
         <h3>
           <FormattedMessage
-            id="kbnVislibVisTypes.controls.gaugeOptions.rangesTitle"
+            id="visTypeVislib.controls.gaugeOptions.rangesTitle"
             defaultMessage="Ranges"
           />
         </h3>
@@ -76,10 +76,10 @@ function RangesPanel({
 
       <SwitchOption
         disabled={stateParams.gauge.colorsRange.length < 2}
-        label={i18n.translate('kbnVislibVisTypes.controls.gaugeOptions.autoExtendRangeLabel', {
+        label={i18n.translate('visTypeVislib.controls.gaugeOptions.autoExtendRangeLabel', {
           defaultMessage: 'Auto extend range',
         })}
-        tooltip={i18n.translate('kbnVislibVisTypes.controls.gaugeOptions.extendRangeTooltip', {
+        tooltip={i18n.translate('visTypeVislib.controls.gaugeOptions.extendRangeTooltip', {
           defaultMessage: 'Extends range to the maximum value in your data.',
         })}
         paramName="extendRange"
@@ -89,7 +89,7 @@ function RangesPanel({
 
       <SwitchOption
         data-test-subj="gaugePercentageMode"
-        label={i18n.translate('kbnVislibVisTypes.controls.gaugeOptions.percentageModeLabel', {
+        label={i18n.translate('visTypeVislib.controls.gaugeOptions.percentageModeLabel', {
           defaultMessage: 'Percentage mode',
         })}
         paramName="percentageMode"
@@ -107,7 +107,7 @@ function RangesPanel({
       />
 
       <SwitchOption
-        label={i18n.translate('kbnVislibVisTypes.controls.gaugeOptions.showOutline', {
+        label={i18n.translate('visTypeVislib.controls.gaugeOptions.showOutline', {
           defaultMessage: 'Show outline',
         })}
         paramName="outline"
@@ -116,7 +116,7 @@ function RangesPanel({
       />
 
       <SwitchOption
-        label={i18n.translate('kbnVislibVisTypes.controls.gaugeOptions.showLegendLabel', {
+        label={i18n.translate('visTypeVislib.controls.gaugeOptions.showLegendLabel', {
           defaultMessage: 'Show legend',
         })}
         paramName="addLegend"
@@ -125,7 +125,7 @@ function RangesPanel({
       />
 
       <SwitchOption
-        label={i18n.translate('kbnVislibVisTypes.controls.gaugeOptions.showScaleLabel', {
+        label={i18n.translate('visTypeVislib.controls.gaugeOptions.showScaleLabel', {
           defaultMessage: 'Show scale',
         })}
         paramName="show"