[Security Solution][Detections] Assignees shown as Unknown in Timelin…

…es (#8028)
elastic · Nov 13, 2023 · 2f0911b · 2f0911b
1 parent 6be8d31
commit 2f0911b
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/.../security_solution/public/timelines/components/timeline/body/renderers/column_renderer.ts b/.../security_solution/public/timelines/components/timeline/body/renderers/column_renderer.ts
@@ -14,7 +14,11 @@ import type { TimelineNonEcsData } from '../../../../../../common/search_strateg
 import type { RenderCellValueContext } from '../../../../../detections/configurations/security_solution_detections/fetch_page_context';
 
 export interface ColumnRenderer {
-  isInstance: (columnName: string, data: TimelineNonEcsData[]) => boolean;
+  isInstance: (
+    columnName: string,
+    data: TimelineNonEcsData[],
+    context?: RenderCellValueContext
+  ) => boolean;
   renderColumn: ({
     className,
     columnName,

diff --git a/...urity_solution/public/timelines/components/timeline/body/renderers/get_column_renderer.ts b/...urity_solution/public/timelines/components/timeline/body/renderers/get_column_renderer.ts
@@ -5,6 +5,7 @@
  * 2.0.
  */
 
+import type { RenderCellValueContext } from '../../../../../detections/configurations/security_solution_detections/fetch_page_context';
 import type { TimelineNonEcsData } from '../../../../../../common/search_strategy/timeline';
 import type { ColumnRenderer } from './column_renderer';
 
@@ -15,10 +16,11 @@ const unhandledColumnRenderer = (): never => {
 export const getColumnRenderer = (
   columnName: string,
   columnRenderers: ColumnRenderer[],
-  data: TimelineNonEcsData[]
+  data: TimelineNonEcsData[],
+  context?: RenderCellValueContext
 ): ColumnRenderer => {
   const renderer = columnRenderers.find((columnRenderer) =>
-    columnRenderer.isInstance(columnName, data)
+    columnRenderer.isInstance(columnName, data, context)
   );
   return renderer != null ? renderer : unhandledColumnRenderer();
 };
diff --git a/...ty_solution/public/timelines/components/timeline/body/renderers/user_profile_renderer.tsx b/...ty_solution/public/timelines/components/timeline/body/renderers/user_profile_renderer.tsx
@@ -16,7 +16,7 @@ import { profileUidColumns } from '../../../../../detections/configurations/secu
 import type { RenderCellValueContext } from '../../../../../detections/configurations/security_solution_detections/fetch_page_context';
 
 export const userProfileColumnRenderer: ColumnRenderer = {
-  isInstance: (columnName) => profileUidColumns.includes(columnName),
+  isInstance: (columnName, _, context) => profileUidColumns.includes(columnName) && !!context,
   renderColumn: ({
     columnName,
     ecsData,

diff --git a/...ty_solution/public/timelines/components/timeline/cell_rendering/default_cell_renderer.tsx b/...ty_solution/public/timelines/components/timeline/cell_rendering/default_cell_renderer.tsx
@@ -50,7 +50,7 @@ export const DefaultCellRenderer: React.FC<CellValueElementProps> = ({
     : 'eui-displayInlineBlock eui-textTruncate';
   return (
     <StyledContent className={styledContentClassName} $isDetails={isDetails}>
-      {getColumnRenderer(header.id, columnRenderers, data).renderColumn({
+      {getColumnRenderer(header.id, columnRenderers, data, context).renderColumn({
         asPlainText: asPlainText ?? asPlainTextDefault, // we want to render value with links as plain text but keep other formatters like badge. Except rule name for non preview tables
         columnName: header.id,
         ecsData,