Skip to content

Commit

Permalink
[build] Update node cleanup paths (#190512)
Browse files Browse the repository at this point in the history
Prior to introducing node variants, we were cleaning up unused files
included with Node.js. The node paths changed, and the cleanup paths
were not. This fixes the issue.

## Testing

`$KIBANA_HOME/node/*` should be cleaned of unused files, see the
patterns in the diff for exact files.
  • Loading branch information
jbudz authored Aug 14, 2024
1 parent 0ecdd14 commit 1ed50e6
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions src/dev/build/tasks/nodejs/clean_node_builds_task.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ export const CleanNodeBuilds: Task = {
for (const platform of config.getTargetPlatforms()) {
await deleteAll(
[
build.resolvePathForPlatform(platform, '*/node/lib/node_modules'),
build.resolvePathForPlatform(platform, '*/node/bin/npm'),
build.resolvePathForPlatform(platform, '*/node/bin/npx'),
build.resolvePathForPlatform(platform, '*/node/bin/corepack'),
build.resolvePathForPlatform(platform, '*/node/CHANGELOG.md'),
build.resolvePathForPlatform(platform, '*/node/README.md'),
build.resolvePathForPlatform(platform, 'node/*/lib/node_modules'),
build.resolvePathForPlatform(platform, 'node/*/bin/npm'),
build.resolvePathForPlatform(platform, 'node/*/bin/npx'),
build.resolvePathForPlatform(platform, 'node/*/bin/corepack'),
build.resolvePathForPlatform(platform, 'node/*/CHANGELOG.md'),
build.resolvePathForPlatform(platform, 'node/*/README.md'),
],
log
);
Expand Down

0 comments on commit 1ed50e6

Please sign in to comment.