Skip to content

Commit

Permalink
Apply explicit typing per code review
Browse files Browse the repository at this point in the history
Co-authored-by: elena-shostak <165678770+elena-shostak@users.noreply.github.com>
  • Loading branch information
tsullivan and elena-shostak authored Jul 31, 2024
1 parent 36ecf51 commit 1d62cb0
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ export class SpacesGridPage extends Component<Props, State> {
defaultMessage: 'Space',
}),
sortable: true,
render: (value: string, rowRecord) => (
render: (value: string, rowRecord: Space) => (
<EuiFlexGroup responsive={false} alignItems="center" gutterSize="m">
<EuiFlexItem grow={false}>
<EuiLink
Expand Down Expand Up @@ -319,7 +319,7 @@ export class SpacesGridPage extends Component<Props, State> {
sortable: (space: Space) => {
return getEnabledFeatures(this.state.features, space).length;
},
render: (_disabledFeatures: string[], rowRecord) => {
render: (_disabledFeatures: string[], rowRecord: Space) => {
const enabledFeatureCount = getEnabledFeatures(this.state.features, rowRecord).length;
if (enabledFeatureCount === this.state.features.length) {
return (
Expand Down Expand Up @@ -427,7 +427,7 @@ export class SpacesGridPage extends Component<Props, State> {
type: 'icon',
icon: 'merge',
color: 'primary',
href: (rowRecord) =>
href: (rowRecord: Space) =>
addSpaceIdToPath(
this.props.serverBasePath,
rowRecord.id,
Expand Down Expand Up @@ -456,7 +456,7 @@ export class SpacesGridPage extends Component<Props, State> {
type: 'icon',
icon: 'trash',
color: 'danger',
onClick: (rowRecord) => this.onDeleteSpaceClick(rowRecord),
onClick: (rowRecord: Space) => this.onDeleteSpaceClick(rowRecord),
enabled: (rowRecord: Space) => !isReservedSpace(rowRecord),
'data-test-subj': (rowRecord) => `${rowRecord.name}-deleteSpace`,
},
Expand Down

0 comments on commit 1d62cb0

Please sign in to comment.