Address review feedback

elastic · Dec 22, 2023 · 165c3cd · 165c3cd
1 parent c76c87e
commit 165c3cd
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/x-pack/plugins/lens/public/datasources/form_based/datapanel.tsx b/x-pack/plugins/lens/public/datasources/form_based/datapanel.tsx
@@ -263,15 +263,7 @@ export const InnerFormBasedDataPanel = function InnerFormBasedDataPanel({
       onSupportedFieldFilter,
       onSelectedFieldFilter,
       onOverrideFieldGroupDetails,
-      getNewFieldsBySpec: (spec, dataView) => {
-        return spec.reduce((result: IndexPatternField[], fieldSpec: FieldSpec) => {
-          const field = new DataViewField(fieldSpec);
-          if (isFieldLensCompatible(field)) {
-            result.push(buildIndexPatternField(field, dataView));
-          }
-          return result;
-        }, []);
-      },
+      getNewFieldsBySpec,
     });
 
   const closeFieldEditor = useRef<() => void | undefined>();
@@ -428,4 +420,14 @@ export const InnerFormBasedDataPanel = function InnerFormBasedDataPanel({
   );
 };
 
+function getNewFieldsBySpec(spec: FieldSpec[], dataView: DataView | null) {
+  return spec.reduce((result: IndexPatternField[], fieldSpec: FieldSpec) => {
+    const field = new DataViewField(fieldSpec);
+    if (isFieldLensCompatible(field)) {
+      result.push(buildIndexPatternField(field, dataView));
+    }
+    return result;
+  }, []);
+}
+
 export const MemoizedDataPanel = memo(InnerFormBasedDataPanel);