Fix lint issues

elastic · Nov 21, 2024 · 13a7b62 · 13a7b62
1 parent 0c7f4dc
commit 13a7b62
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 11 deletions.
diff --git a/x-pack/plugins/observability_solution/observability_ai_assistant/server/plugin.ts b/x-pack/plugins/observability_solution/observability_ai_assistant/server/plugin.ts
@@ -120,13 +120,19 @@ export class ObservabilityAIAssistantPlugin
       config: this.config,
     }));
 
-    setupConversationAndKbIndexAssets({ core, logger: this.logger }).then(() => {
-      return registerMigrateKnowledgeBaseEntriesTask({
-        core,
-        taskManager: plugins.taskManager,
-        logger: this.logger,
+    setupConversationAndKbIndexAssets({ core, logger: this.logger })
+      .then(() => {
+        return registerMigrateKnowledgeBaseEntriesTask({
+          core,
+          taskManager: plugins.taskManager,
+          logger: this.logger,
+        });
+      })
+      .catch((e) => {
+        this.logger.error(
+          `Observability Assistant assets were not setup successfully: ${e.message}`
+        );
       });
-    });
 
     service.register(registerFunctions);
 

diff --git a/...ution/observability_ai_assistant/server/service/setup_conversation_and_kb_index_assets.ts b/...ution/observability_ai_assistant/server/service/setup_conversation_and_kb_index_assets.ts
@@ -104,6 +104,5 @@ export async function setupConversationAndKbIndexAssets({
   } catch (error) {
     logger.error(`Failed setting up index assets: ${error.message}`);
     logger.debug(error);
-    throw error;
   }
 }
diff --git a/...t/server/service/task_manager_definitions/register_migrate_knowledge_base_entries_task.ts b/...t/server/service/task_manager_definitions/register_migrate_knowledge_base_entries_task.ts
@@ -134,7 +134,7 @@ export async function runSemanticTextKnowledgeBaseMigration({
     logger.debug(`Knowledge base migration: Migrated ${promises.length} entries`);
     await runSemanticTextKnowledgeBaseMigration({ esClient, logger });
   } catch (e) {
-    logger.error('Knowledge base migration: Failed to migrate entries');
+    logger.error(`Knowledge base migration failed: ${e.message}`);
     logger.error(e);
   }
 }
diff --git a/...est/observability_ai_assistant_api_integration/tests/complete/functions/summarize.spec.ts b/...est/observability_ai_assistant_api_integration/tests/complete/functions/summarize.spec.ts
@@ -19,7 +19,6 @@ import { clearKnowledgeBase } from '../../knowledge_base/helpers';
 export default function ApiTest({ getService }: FtrProviderContext) {
   const supertest = getService('supertest');
   const log = getService('log');
-  const ml = getService('ml');
   const es = getService('es');
   const observabilityAIAssistantAPIClient = getService('observabilityAIAssistantAPIClient');
 

diff --git a/...st/observability_ai_assistant_api_integration/tests/knowledge_base/knowledge_base.spec.ts b/...st/observability_ai_assistant_api_integration/tests/knowledge_base/knowledge_base.spec.ts
@@ -11,7 +11,6 @@ import { FtrProviderContext } from '../../common/ftr_provider_context';
 import { clearKnowledgeBase } from './helpers';
 
 export default function ApiTest({ getService }: FtrProviderContext) {
-  const ml = getService('ml');
   const es = getService('es');
   const observabilityAIAssistantAPIClient = getService('observabilityAIAssistantAPIClient');
 

diff --git a/...bility_ai_assistant_api_integration/tests/knowledge_base/knowledge_base_migration.spec.ts b/...bility_ai_assistant_api_integration/tests/knowledge_base/knowledge_base_migration.spec.ts
@@ -17,7 +17,6 @@ export default function ApiTest({ getService }: FtrProviderContext) {
   const observabilityAIAssistantAPIClient = getService('observabilityAIAssistantAPIClient');
   const esArchiver = getService('esArchiver');
   const es = getService('es');
-  const ml = getService('ml');
 
   const archive =
     'x-pack/test/functional/es_archives/observability/ai_assistant/knowledge_base_8_15';