Fix TS issue

elastic · Oct 10, 2024 · 12fb260 · 12fb260
1 parent a562edd
commit 12fb260
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 4 deletions.
diff --git a/packages/shared-ux/chrome/navigation/__jest__/utils.tsx b/packages/shared-ux/chrome/navigation/__jest__/utils.tsx
@@ -39,6 +39,7 @@ export const getServicesMock = (): NavigationServices => {
     activeNodes$: of(activeNodes),
     isSideNavCollapsed: false,
     eventTracker,
+    isFeedbackBtnVisible$: of(false),
   };
 };
 

diff --git a/packages/shared-ux/chrome/navigation/mocks/storybook.ts b/packages/shared-ux/chrome/navigation/mocks/storybook.ts
@@ -9,7 +9,7 @@
 
 import { AbstractStorybookMock } from '@kbn/shared-ux-storybook-mock';
 import { action } from '@storybook/addon-actions';
-import { BehaviorSubject } from 'rxjs';
+import { BehaviorSubject, of } from 'rxjs';
 import { EventTracker } from '../src/analytics';
 import { NavigationServices } from '../src/types';
 
@@ -43,6 +43,7 @@ export class StorybookMock extends AbstractStorybookMock<{}, NavigationServices>
       activeNodes$: params.activeNodes$ ?? new BehaviorSubject([]),
       isSideNavCollapsed: true,
       eventTracker: new EventTracker({ reportEvent: action('Report event') }),
+      isFeedbackBtnVisible$: of(false),
     };
   }
 

diff --git a/packages/shared-ux/chrome/navigation/src/services.tsx b/packages/shared-ux/chrome/navigation/src/services.tsx
@@ -51,7 +51,6 @@ export const NavigationKibanaProvider: FC<PropsWithChildren<NavigationKibanaDepe
       selectedPanelNode,
       setSelectedPanelNode: chrome.sideNav.setPanelSelectedNode,
       isFeedbackBtnVisible$: chrome.sideNav.getIsFeedbackBtnVisible$(),
-      setIsFeedbackBtnVisible: chrome.sideNav.setIsFeedbackBtnVisible,
     }),
     [
       activeNodes$,

diff --git a/packages/shared-ux/chrome/navigation/src/types.ts b/packages/shared-ux/chrome/navigation/src/types.ts
@@ -42,7 +42,6 @@ export interface NavigationServices {
   selectedPanelNode?: PanelSelectedNode | null;
   setSelectedPanelNode?: (node: PanelSelectedNode | null) => void;
   isFeedbackBtnVisible$: Observable<boolean>;
-  setIsFeedbackBtnVisible: (isVisible: boolean) => void;
 }
 
 /**
@@ -63,7 +62,6 @@ export interface NavigationKibanaDependencies {
         getPanelSelectedNode$: () => Observable<PanelSelectedNode | null>;
         setPanelSelectedNode(node: string | PanelSelectedNode | null): void;
         getIsFeedbackBtnVisible$: () => Observable<boolean>;
-        setIsFeedbackBtnVisible: (isVisible: boolean) => void;
       };
     };
     http: {