troubleshooting recursion issue

elastic · Feb 5, 2015 · 06ffa8e · 06ffa8e
1 parent f87f255
commit 06ffa8e
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/src/kibana/components/vislib/visualizations/pie_chart.js b/src/kibana/components/vislib/visualizations/pie_chart.js
@@ -178,12 +178,10 @@ define(function (require) {
       return sizes.some(this._isZero);
     };
 
-    PieChart.prototype._removeZeroNodes = function () {
-      // use the this.chartData
-      // traverse the parent child objects
-      // check whether size is zero
-      // if zero, remove object
-      // return modified data
+    PieChart.prototype._removeZeroNodes = function (arr) {
+      return arr.filter(function (obj) {
+        return (obj.size !== 0);
+      });
     };
 
     /**
@@ -199,7 +197,7 @@ define(function (require) {
       if (!isAllZeros && !isSomeZeros) { return; }
 
       if (isSomeZeros) {
-        this._removeZeroNodes();
+        return this._removeZeroNodes();
       }
 
       throw new errors.PieContainsAllZeros();