-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Elastic Package Registry integration to use new indexer metrics (get operations) #3863
Update Elastic Package Registry integration to use new indexer metrics (get operations) #3863
Conversation
🌐 Coverage report
|
@@ -1,4 +1,4 @@ | |||
FROM docker.elastic.co/package-registry/package-registry:v1.10.0 | |||
FROM docker.elastic.co/package-registry/package-registry:a69ff8a9937bbf9e21b47be3cb94a1d254e2d145 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be updated with a newer tag of a new package-registry release containing this PR elastic/package-registry#853.
- name: package_registry.storage_indexer | ||
- name: package_registry.indexer | ||
type: group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently , there will be just one metric (get_duration_seconds) in this indexer
group. It seems to me that it could make sense to have that group even that.
WDYT?
These are the current groups defined:
- package_registry.http
- package_registry.labels
- package_registry.indexer
- package_registry.storage_indexer
@@ -1,4 +1,4 @@ | |||
FROM docker.elastic.co/package-registry/package-registry:v1.10.0 | |||
FROM docker.elastic.co/package-registry/package-registry:a69ff8a9937bbf9e21b47be3cb94a1d254e2d145 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe drop a comment on why exactly is this SHA needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok! I'll do that, and in following PR, I'll set the the newer tag of the package registry
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the end, there has been a package-registry release, so no need to use the SHA. I'll update it to v1.11.0
What does this PR do?
This PR updates the Elastic Package Registry integration to take into account the new metrics related to get operations (duration histograms) from elastic/package-registry#853.
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
packages/elastic_package_registry
and build the package (elastic-package build
).packages/elastic_package_registry
folder.elastic-package service up -v
inside thepackages/elastic_package_registry
folderelastic-package-service_elastic_package_registry_1
http://elastic-package-service_elastic_package_registry_1:9100
metrics-*
. It can be filtered by:service.type: elastic_package_registry
data_stream.dataset: elastic_package_registry.metrics
docker ps
curl -s http://localhost:53910/ curl -s http://localhost:53910/health curl -s http://localhost:53910/search?prerelease=true ...
Related issues
Screenshots