Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ecs suffixes #347

Merged
merged 6 commits into from
Oct 28, 2020
Merged

Remove ecs suffixes #347

merged 6 commits into from
Oct 28, 2020

Conversation

ycombinator
Copy link
Contributor

What does this PR do?

This PR removes -ecs suffixes from Kibana asset IDs and their references. It also removes ECS from any asset titles, labels, etc.

Related issues

@ycombinator ycombinator requested a review from mtojek October 28, 2020 08:37
@ycombinator ycombinator added the Team:Integrations Label for the Integrations team label Oct 28, 2020
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #347 opened]

  • Start Time: 2020-10-28T08:37:48.662+0000

  • Duration: 8 min 9 sec

Test stats 🧪

Test Results
Failed 0
Passed 8
Skipped 0
Total 8

@ycombinator ycombinator merged commit 3f315f2 into elastic:master Oct 28, 2020
@ycombinator ycombinator deleted the remove-ecs-suffixes branch October 28, 2020 08:58
@ycombinator ycombinator mentioned this pull request Oct 28, 2020
Merged
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@ycombinator
Remove ecs suffixes (elastic#347)
90b68de 
* Remove -ecs suffixes from Kibana asset filenames

* Removing -ecs suffix from asset IDs and references

* Removing -ecs from more references

* Remove " ECS" from labels, titles, etc. + more reference updates

* One more reference update

* Bumping up versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtojek mtojek mtojek approved these changes

Assignees
No one assigned
Labels
Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove -ecs suffix from existing Integrations packages' Kibana asset IDs
3 participants
@ycombinator @elasticmachine @mtojek