Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ECS host fields to system package log data streams #313

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Add ECS host fields to system package log data streams #313

merged 1 commit into from
Oct 19, 2020

Conversation

andrewkroh
Copy link
Member

What does this PR do?

Add missing field definitions for the ECS host fields to the log data streams of the system package.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all datasets collect metrics or logs.

Author's Checklist

  • Test this with Elastic Agent (had trouble running latest agent)

Related issues

@andrewkroh andrewkroh added the bug Something isn't working, use only for issues label Oct 15, 2020
@elasticmachine
Copy link

elasticmachine commented Oct 15, 2020 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #313 updated]

  • Start Time: 2020-10-15T22:40:41.919+0000

  • Duration: 21 min 6 sec

@andrewkroh
Add ECS host fields to system package
ff4e69b 
Add missing field definitions for the ECS host fields to the log data streams of the system package.

Fixes #291
@elasticmachine
Copy link

Pinging @elastic/integrations-services (Team:Services)

@andresrc
Copy link
Collaborator

Thanks Andrew!!

fearful-symmetry
fearful-symmetry approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@fearful-symmetry fearful-symmetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You actually beat me to this, was about halfway done with a PR. I've been having trouble getting agent to run under linux, though, so didn't get to testing.

@andrewkroh andrewkroh merged commit 8bed7d6 into elastic:master Oct 19, 2020
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@andrewkroh
Add ECS host fields to system package (elastic#313)
c01afff 
Add missing field definitions for the ECS host fields to the log data streams of the system package.

Fixes elastic#291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fearful-symmetry fearful-symmetry fearful-symmetry approved these changes

@mtojek mtojek mtojek approved these changes

Assignees
No one assigned
Labels
bug Something isn't working, use only for issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

System package is missing ECS host.ip field mapping
5 participants
@andrewkroh @elasticmachine @andresrc @fearful-symmetry @mtojek