Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imperva_cloud_waf: improve error reporting for API requests #12648

Merged
merged 2 commits into from
Feb 10, 2025
Merged

imperva_cloud_waf: improve error reporting for API requests #12648

merged 2 commits into from
Feb 10, 2025

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Feb 7, 2025 •
edited
Loading

Proposed commit message

Improve error reporting for non-200 responses and also ensure that the
password is redacted.

Note

The cel input is not tested due to limitations in elastic package (only one deployment).

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] Integration:imperva_cloud_waf Imperva Cloud WAF labels Feb 7, 2025
@efd6 efd6 self-assigned this Feb 7, 2025
@efd6 efd6 force-pushed the imperva_cloud_waf_errorhandling branch from e643927 to 9ba60b6 Compare February 7, 2025 02:09
@elastic-vault-github-plugin-prod
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 marked this pull request as ready for review February 7, 2025 02:48
@efd6 efd6 requested a review from a team as a code owner February 7, 2025 02:48
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

kcreddy
kcreddy reviewed Feb 7, 2025
View reviewed changes
packages/imperva_cloud_waf/data_stream/event/agent/stream/cel.yml.hbs
),
},
},
"want_more": false,
Copy link
Contributor

@kcreddy kcreddy Feb 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return state doesn't seem to be enclosed using state.with().
In that case, don't we need to add user, password inside each of these error cases as well?

Also may need to redact the password.

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

@efd6 efd6 merged commit 109c93b into elastic:main Feb 10, 2025
6 checks passed
@elastic-vault-github-plugin-prod
Copy link

Package imperva_cloud_waf - 1.6.0 containing this change is available at https://epr.elastic.co/package/imperva_cloud_waf/1.6.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@efd6 efd6

Labels
enhancement New feature or request Integration:imperva_cloud_waf Imperva Cloud WAF Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @kcreddy