[docker] use ecs definition of the 'event.dataset' field for container_logs #11672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
packages/docker/data_stream/container_logs/agent/stream/stream.yml.hbs
Outdated
Show resolved
Hide resolved
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
|
@MichaelKatsoulis @gizas can you please review this PR? |
| {{/if}} |
There was a problem hiding this comment.
No need for the extra line
MichaelKatsoulis
approved these changes
Nov 12, 2024
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
|
/test |
💚 Build Succeeded
History
|
|
|
Package docker - 2.12.0 containing this change is available at https://epr.elastic.co/package/docker/2.12.0/ |
harnish-elastic
pushed a commit
to harnish-elastic/integrations
that referenced
this pull request
Feb 4, 2025
…r_logs (elastic#11672) * Use ecs definition of the 'event.dataset' field for container_logs Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * change pr link; fix field description Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * Use ecs definition of the 'event.dataset' field for all datastreams Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * remove empty line Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> --------- Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
harnish-elastic
pushed a commit
to harnish-elastic/integrations
that referenced
this pull request
Feb 5, 2025
…r_logs (elastic#11672) * Use ecs definition of the 'event.dataset' field for container_logs Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * change pr link; fix field description Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * Use ecs definition of the 'event.dataset' field for all datastreams Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * remove empty line Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> --------- Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots