Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Nats] update nats ECS version and add event.original options #1061

Merged
merged 4 commits into from
Jun 9, 2021
Merged

[Nats] update nats ECS version and add event.original options #1061

merged 4 commits into from
Jun 9, 2021

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Jun 1, 2021

What does this PR do?

Updates package ECS version to 1.10.
Sync module changes to packages if any.
Adds Preserve Raw event functionality if not already exists.
Adds pipeline tests if missing.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Related issues

@P1llus P1llus added enhancement New feature or request Team:Integrations Label for the Integrations team Team:Security-External Integrations Integration:nats NATS labels Jun 1, 2021
@P1llus P1llus mentioned this pull request Jun 1, 2021
Closed
@elasticmachine
Copy link

elasticmachine commented Jun 1, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1061 updated

  • Start Time: 2021-06-09T12:08:15.483+0000

  • Duration: 22 min 9 sec

  • Commit: eade9c0

Test stats 🧪

Test Results
Failed 0
Passed 49
Skipped 0
Total 49

Trends 🧪

Image of Build Times

Image of Tests

@P1llus P1llus marked this pull request as ready for review June 7, 2021 14:32
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@kaiyan-sheng kaiyan-sheng requested a review from ChrsMark June 7, 2021 20:43
ChrsMark
ChrsMark approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@P1llus P1llus merged commit 7842ee1 into elastic:master Jun 9, 2021
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@P1llus
[Nats] update nats ECS version and add event.original options (elasti…
cc20221 
…c#1061)

* update nats ECS version and add event.original options

* update manifest, changelog and linting

* Linting and updating manifest

* update changelog and linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Integration:nats NATS Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@P1llus @elasticmachine @ChrsMark