This repository has been archived by the owner on May 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[docs] Improve visibility of 6.8 and 7.x releases #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgreau
reviewed
Jun 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @fatmcgav for helping to clarify the process.
I left a couple of comments.
For example if you want to deploy an Elasticsearch `7.5.1` cluster, use the | ||
corresponding `7.5.1` [tag][elasticsearch-751]. | ||
|
||
The `master` version of these charts are intended to support the latest pre-release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should wait for @jmlrt's PR to be merged before merging this one and then update these instructions to clearly explain that:
- the
master
branch is used for testing the latest snapshot versions of our products - we don't recommend using the
master
git branch for production deployment but instead either the git tags or the https://helm.elastic.co repository which contain the versions tested and released by Elastic
Remove mention of `6.8` GA Co-authored-by: Maxime Gréau <maxime.greau@elastic.co>
Switch example to `7.7.1` chart version.
jmlrt
approved these changes
Jun 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM⛴
Should be merged after #682
jmlrt
pushed a commit
that referenced
this pull request
Jun 29, 2020
Co-authored-by: Maxime Gréau <maxime.greau@elastic.co>
jmlrt
pushed a commit
that referenced
this pull request
Jun 29, 2020
Co-authored-by: Maxime Gréau <maxime.greau@elastic.co>
jmlrt
pushed a commit
that referenced
this pull request
Jun 29, 2020
Co-authored-by: Maxime Gréau <maxime.greau@elastic.co>
backported to |
Closed
This was referenced Nov 17, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 14, 2021
Merged
Merged
Merged
This was referenced Sep 14, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #688, the docs for the
master
branch provide documentation and examples for the "latest" version.So if users are trying to install a 6.x ES cluster, the examples may not work.
This PR adds the "latest" release versions to the Charts table, and updates the docs to better call out the preference to match the chart version to the product version.