-
Notifications
You must be signed in to change notification settings - Fork 1.9k
graceful termination handler for master nodes #119
graceful termination handler for master nodes #119
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested a few minor tweaks. Apart from that this is looking fantastic! I tested it out and it is working exactly as expected!
Thank you again so much for your persistence in getting this working :)
Applied changes |
jenkins test this please |
build failed because of google storage failures (even with retries):
jenkins test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you again so much for your persistence in working on this!
@kimxogus @Crazybus is this additional container needed for all versions? as I understand it should be fixed as mentioned #63 (comment), maybe it makes sense to introduce additional value and add this container optionally? wdyt? |
Rewrote #108 with reference #63 (comment)
fixes #63 for all es versions!
${CHART}/tests/*.py
${CHART}/examples/*/test/goss.yaml