Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Remove GitHub pages hosted docs #7213

Merged
merged 3 commits into from
Sep 21, 2023
Merged

[Docs] Remove GitHub pages hosted docs #7213

merged 3 commits into from
Sep 21, 2023

Conversation

cee-chen
Copy link
Contributor

@cee-chen cee-chen commented Sep 21, 2023 •
edited
Loading

Summary

Now that Buildkite's release automation and caching is working nicely, we can remove our GitHub-hosted docs entirely in favor of https://eui.elastic.co.

QA

General checklist

  • N/A, docs only

@cee-chen cee-chen added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog labels Sep 21, 2023
@cee-chen cee-chen marked this pull request as ready for review September 21, 2023 19:21
@cee-chen cee-chen requested a review from a team as a code owner September 21, 2023 19:21
@cee-chen cee-chen self-assigned this Sep 21, 2023
1Copenut
1Copenut approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@1Copenut 1Copenut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. I stepped through the second and third commits instead of the /files URL to see the important changes.

I followed the QA steps and checked that I saw a 301: Permanent redirect HTTP code on the GitHub URL.

@cee-chen cee-chen enabled auto-merge (squash) September 21, 2023 19:47
@cee-chen
Copy link
Contributor Author

It's happening!

@kibanamachine
Copy link

Preview staging links for this PR:

@cee-chen cee-chen merged commit 038a697 into elastic:main Sep 21, 2023
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @cee-chen

@cee-chen cee-chen deleted the remove-github-pages-docs branch September 21, 2023 20:00
@cee-chen cee-chen mentioned this pull request Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1Copenut 1Copenut 1Copenut approved these changes

Assignees

@cee-chen cee-chen

Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cee-chen @kibanamachine @elasticmachine @1Copenut