Update EuiDualRange to support passing more props to underlying range inputs #6902
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6902/ |
src/components/form/range/__snapshots__/dual_range.test.tsx.snap
Outdated
Show resolved
Hide resolved
| }); | ||
| }); | ||
|
|
||
| it('renders slider role elements as disabled when disabled=true', () => { |
There was a problem hiding this comment.
thanks for the thoroughness with these tests, seriously! 🎉
| it('applies passed props to max input', () => { | ||
| const { container } = render( |
There was a problem hiding this comment.
[super optional, not a change request] would it be worth it to add a test checking that we allow overriding the default props? Something like
<EuiDualRange
disabled
maxInputProps={{ disabled: false }}
/>
// check that `maxInputProps` took precedence
958c261 to
819f024
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6902/ |
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
There was a problem hiding this comment.
Changes LGTM! Let's get this merged in!
FYI @Heenawter, since we discussed this a while back - this should be landing in Kibana hopefully end of this week or the next week :)
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6902/ |
|
jenkins test this please |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6902/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6902/ |
## Summary `eui@83.1.0` ⏩ `eui@84.0.0` --- ## [`84.0.0`](https://github.com/elastic/eui/tree/v84.0.0) - Updated `EuiDualRange`'s `minInputProps` and `maxInputProps` to support passing more props to underlying inputs ([#6902](elastic/eui#6902)) - `EuiFocusTrap` now supports configuring cross-iframe focus trapping via the `crossFrame` prop ([#6908](elastic/eui#6908)) **Bug fixes** - Fixed `EuiFilterButton` icon display ([#6900](elastic/eui#6900)) - Fixed `EuiCombobox` compressed plain text display ([#6910](elastic/eui#6910)) - Fixed visual appearance of collapse buttons on collapsible `EuiResizablePanel`s ([#6926](elastic/eui#6926)) **Breaking changes** - `EuiFocusTrap` now defaults to *not* trapping focus across iframes ([#6908](elastic/eui#6908)) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Summary
This PR updates EuiDualRange to support passing more props to underlying EuiRangeInput components using
minInputPropsandmaxInputProps.It's a fix for #6853 we came up with after a few iterations of possible solutions.
QA
General checklist