[EuiDataGrid] When a cell expansion popover is closed, ensure focus is always returned to the originating cell for keyboard users #5761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24cc559 to
efaf0be
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5761/ |
2836072 to
9b007ae
Compare
9b007ae to
44d3016
Compare
|
Tested and confirmed that the last 2 added Cypress tests fail on main but pass on this branch. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5761/ |
1Copenut
approved these changes
Apr 5, 2022
| cy.realMount(<EuiDataGrid {...baseProps} />); | ||
| cy.get( | ||
| '[data-gridcell-row-index="0"][data-gridcell-column-index="0"]' | ||
| ).click(); |
There was a problem hiding this comment.
What do you think about swapping these .click() events for .realClick() ones? https://github.com/dmtrKovalenko/cypress-real-events#cyrealclick
If that causes issues for clicks that need a { force: true } object, I'm okay sticking with the current implementation.
4 tasks
|
Ooo, it looks like |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5761/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes #5646 by manually returning
.focus()to the originating cell when a popover is closed by keyboard users (the escape key or the F2 key). This applies to two separate buggy use cases:Before
After
Checklist
- [ ] Checked in both light and dark modes- [ ] Checked in mobile- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for any docs examples- [ ] Checked for breaking changes and labeled appropriately- [ ] Updated the Figma library counterpart