Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major version dependency upgrades, pt. III; Docker bonus #4062

Merged
merged 16 commits into from
Oct 2, 2020
Merged

Major version dependency upgrades, pt. III; Docker bonus #4062

merged 16 commits into from
Oct 2, 2020

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Sep 21, 2020 •
edited
Loading

Summary

Partial resolution of #3969: testing-adjacent dependencies

  • Removed all scripts and dependencies related to visual regression testing (never used)
  • Updated core-js
  • Updated puppeteer
  • Update jest in the minor range
    • Need to upgrade TypeScript to >=3.8 before going to 26.x
    • require.requireActual (removed in 26.x) no longer bypasses moduleNameMapper, hence changes to the icon mock

eui/puppeteer

Upgraded puppeteer requires node.js >=10.18, which aligns with our overall version requirements, but the Docker image in use for automated accessibility testing was pinned to 10.15 and unmaintained. Hence the addition of docker-puppeteer, in which we can maintain and publish our own Docker images using the Elastic Container Registry.

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in Chrome, Safari, Edge, and Firefox
- [ ] Props have proper autodocs
- [ ] Added documentation
- [ ] Checked Code Sandbox works for the any docs examples
- [ ] Added or updated jest tests

  • Checked for breaking changes and labeled appropriately

- [ ] Checked for accessibility including keyboard-only and screenreader modes

  • A changelog entry exists and is marked appropriately

@thompsongl thompsongl added the dependencies Pull requests that update a dependency file label Sep 21, 2020
@thompsongl thompsongl mentioned this pull request Sep 21, 2020
Closed
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4062/

@thompsongl
Copy link
Contributor Author

puppeteer upgrade causing compatibility issues with the Docker image used for axe testing. Looking into solutions.

@thompsongl
Copy link
Contributor Author

In the process of changing Docker images for axe testing, which also involves switching to use the Elastic registry. Track progress in elastic/infra#23511

@thompsongl thompsongl changed the title Major version dependency upgrades, pt. III Major version dependency upgrades, pt. III; Docker bonus Sep 28, 2020
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4062/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4062/

@thompsongl thompsongl marked this pull request as ready for review September 29, 2020 15:17
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4062/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4062/

chandlerprall
chandlerprall approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4062/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4062/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4062/

@thompsongl thompsongl merged commit f4813c5 into elastic:master Oct 2, 2020
@chandlerprall chandlerprall mentioned this pull request Oct 15, 2020
Merged
kshitij86 added a commit to kshitij86/eui that referenced this pull request Nov 29, 2020
@kshitij86
Major version dependency upgrades, pt. III; Docker bonus (elastic#4062)
89be634 
* version updates

* remove visual regression test setup

* core-js changes

* yarn.lock

* clean up

* use eui/puppeteer image on elastic registry; docs

* use the correct name; update docs

* clean up

* pin docker image to node 10.22.1

* update CL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thompsongl @kibanamachine @chandlerprall