-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade elastic charts 19.6.3 #3669
Conversation
- upgrade elastic charts to 19.6.1 - add background.color to eui chart theme
Thanks @nickofthyme ! Since this updates a peer-dependency and a consumed output file, it will need a changelog. |
Ok thanks, I added a note about the src changes. I wasn't sure what you meant by the peer dependency changes because none of the peer dependencies of |
Pulled up the package.json & yarn.lock changes and compared with our devDeps & peerDeps, this change only affects the former and not peerDeps. No changelog needed (for that change, the background color one is still needed as you have it), but thank you @cchaos for thinking of it! |
Ok thanks for the clarification. Thanks @chandlerprall and @cchaos for the review! 👍 |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3669/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll eventually revisit how we are actually doing this and probably want document it. I'll make a note or issue for follow-up.
Meant to also say THANK YOU @nickofthyme ! |
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Preview documentation changes for this PR: https://eui.elastic.co/pr_3669/ |
Summary
19.6.3
Checklist