-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add displayAsText props to EuiDataGridColumn #3520
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
@chandlerprall Thanks for the suggestions. Changes committed 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM; Pulled and tested locally, will merge on green CI
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3520/ |
* Add displayAsText props to column type * Column selector must show dispalyAsTest if it exists * Use displayAsText instead of id * Add displayAsText to EuiDataGridSorting interface * Added example in docs * Add cl * Rever changes * Removed display as test * Updated info of props * Use displayValues to get displayAsText from id * Move displayValues to data grid * Updated comment
@ashikmeerankutty This PR missed applying
|
@timroes Sorry I missed that. I was aware of this issue while creating this PR but I missed to comment about it. eui/src/components/datagrid/column_sorting.tsx Lines 176 to 178 in 1bc2b29
|
Yes that sounds right. And then we can just pass the display as string value to the too. |
I will make a PR |
Summary
Fixes #3421
Added a
displayAsText
prop that will be shown in column popover and sorting popover of EuiDataGrid.Checklist
- [ ] Checked in IE11 and Firefox- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes