Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve contrast for EuiCollapsibleNav close link #3465

Merged
merged 12 commits into from
May 13, 2020
Merged

Improve contrast for EuiCollapsibleNav close link #3465

merged 12 commits into from
May 13, 2020

Conversation

elizabetdev
Copy link
Contributor

@elizabetdev elizabetdev commented May 12, 2020 •
edited by ryankeairns
Loading

Summary

This PR closes #3402

With this PR I'm improving the contrast for the EuiCollapsibleNav close link.

Implementation@2x

A few decisions:

  • During the implementation, I decided to keep the EuiButtonEmpty because it was the most similar button to what I wanted to achieve.
  • Since this button was only implemented to keyboard users I used the <EuiScreenReaderOnly showOnFocus> component and added a visible focus ring as suggested by @chaos.

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • [ ] Props have proper autodocs
  • [ ] Added documentation examples
  • Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@elizabetdev elizabetdev requested review from cchaos and ryankeairns May 12, 2020 11:39
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3465/

ryankeairns
ryankeairns approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I did not review the code but tested this out in the preview link. Navigation worked as expected; design looked as described. Thanks @miukimiu

cchaos
cchaos suggested changes May 12, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I have a suggestion around trying to avoid targeting other component specific classes.

@elizabetdev elizabetdev requested a review from cchaos May 12, 2020 19:45
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3465/

@elizabetdev elizabetdev requested a review from cchaos May 13, 2020 13:03
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3465/

elizabetdev and others added 3 commits May 13, 2020 14:46
@elizabetdev @cchaos
Update src/components/collapsible_nav/collapsible_nav.tsx
f4d8020 
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
@elizabetdev @cchaos
Update src/components/collapsible_nav/_collapsible_nav.scss
480bc70 
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
@elizabetdev
Updating test
1726be9
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3465/

cchaos
cchaos approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This behavior and look is much better now 💯

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3465/

@elizabetdev elizabetdev merged commit 9af2bbd into master May 13, 2020
@elizabetdev elizabetdev deleted the contrast-collapsible-nav-close-link branch May 28, 2020 17:11
@thompsongl thompsongl mentioned this pull request Jun 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

@cchaos cchaos cchaos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve contrast for EuiCollapsibleNav close link
4 participants
@elizabetdev @kibanamachine @ryankeairns @cchaos