Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added direction, justifyContent, and alignItems props on EuiFlexItem #3069

Closed
wants to merge 3 commits into from

Conversation

anishagg17
Copy link
Contributor

@anishagg17 anishagg17 commented Mar 13, 2020

Summary

Fixes : #1888

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cchaos
Copy link
Contributor

cchaos commented Mar 14, 2020

We have mostly delayed work on issue #1888 because there may be implications with the implementation that need to be discussed hence the discussion label has not been removed from that issue. I'll mark this PR as discussion as well and as a team we will make a decision whether we should proceed with this solution or not. Thanks!

@snide
Copy link
Contributor

snide commented Mar 17, 2020

We discussed this one as a team and decided to close out this PR and the related issue as unnecessary. We're a little worried this could cause a little too much downstream variance and make it harder to support.

Apologies. This was an older issue we hadn't thought on much till this brought it back from slumber.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support direction, justifyContent, and alignItems props on EuiFlexItem
4 participants