-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mock EuiIcon
in Jest
#2878
Mock EuiIcon
in Jest
#2878
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_2878/ |
That comment was a test that I ran locally. Probably not an accurate rendering of this PR's change. 😄 |
Preview documentation changes for this PR: https://eui.elastic.co/pr_2878/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_2878/ |
Inverted the mocking approach
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snapshot updates look good. All tests pass and docs build.
Preview documentation changes for this PR: https://eui.elastic.co/pr_2878/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_2878/ |
Summary
Uses the new
testenv
mock to replaceEuiIcon
in snapshot test output, eliminating the loading/loaded churn sometimes seen with async usage.Closes #2765
Typical resulting diff is something like:
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Checked for accessibility including keyboard-only and screenreader modes