Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent checkbox focus ring from getting clipped in tables #2770

Merged
merged 5 commits into from
Jan 17, 2020
Merged

Prevent checkbox focus ring from getting clipped in tables #2770

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c9fd008
increase hardcoded value of checkbox cells in table's header
andreadelrio Jan 17, 2020
86ac5f7
removed unneeded hardcoded width in EuiBasicTable
andreadelrio Jan 17, 2020
e65ca78
Merge remote-tracking branch 'upstream/master' into checkbox-focus
andreadelrio Jan 17, 2020
ae8e65f
added cl
andreadelrio Jan 17, 2020
adf6bd0
updated cl
andreadelrio Jan 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
- Converted `EuiFormRow` to Typescript ([#2712](https://github.com/elastic/eui/pull/2712))
- Updated `logoAPM`, `logoSecurity` and `logoEnterpriseSearch`. Added `logoWorkplaceSearch` and `logoObservability` ([#2769](https://github.com/elastic/eui/pull/2769))

**Bug fixes**

- Removed inline width from `EuiTableHeaderCellCheckbox`in `EuiBasicTable` to prevent `EuiCheckbox`'s focus ring from getting clipped ([#2770](https://github.com/elastic/eui/pull/2770))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe reword this to be about increasing the width... "- Increased column width on EuiTableHeaderCellCheckox in..."


**Deprecations**

- `EuiIcon`'s `logoEnterpriseSearch` type deprecated in favor of `logoWorkplaceSearch`
Expand Down
2 changes: 1 addition & 1 deletion src-docs/src/views/tables/custom/custom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ export default class extends Component {
id: 'checkbox',
isCheckbox: true,
textOnly: false,
width: '24px',
width: '32px',
},
{
id: 'type',
Expand Down
8 changes: 0 additions & 8 deletions src/components/basic_table/__snapshots__/basic_table.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,7 +741,6 @@ exports[`EuiBasicTable footers render with pagination, selection, sorting, and f
<EuiTableHeader>
<EuiTableHeaderCellCheckbox
key="_selection_column_h"
width="24px"
>
<EuiI18n
default="Select all rows"
Expand Down Expand Up @@ -1734,7 +1733,6 @@ exports[`EuiBasicTable with pagination and selection 1`] = `
<EuiTableHeader>
<EuiTableHeaderCellCheckbox
key="_selection_column_h"
width="24px"
>
<EuiI18n
default="Select all rows"
Expand Down Expand Up @@ -2050,7 +2048,6 @@ exports[`EuiBasicTable with pagination, selection and sorting 1`] = `
<EuiTableHeader>
<EuiTableHeaderCellCheckbox
key="_selection_column_h"
width="24px"
>
<EuiI18n
default="Select all rows"
Expand Down Expand Up @@ -2243,7 +2240,6 @@ exports[`EuiBasicTable with pagination, selection, sorting and a single record a
<EuiTableHeader>
<EuiTableHeaderCellCheckbox
key="_selection_column_h"
width="24px"
>
<EuiI18n
default="Select all rows"
Expand Down Expand Up @@ -2529,7 +2525,6 @@ exports[`EuiBasicTable with pagination, selection, sorting and column dataType 1
<EuiTableHeader>
<EuiTableHeaderCellCheckbox
key="_selection_column_h"
width="24px"
>
<EuiI18n
default="Select all rows"
Expand Down Expand Up @@ -2722,7 +2717,6 @@ exports[`EuiBasicTable with pagination, selection, sorting and column renderer 1
<EuiTableHeader>
<EuiTableHeaderCellCheckbox
key="_selection_column_h"
width="24px"
>
<EuiI18n
default="Select all rows"
Expand Down Expand Up @@ -2915,7 +2909,6 @@ exports[`EuiBasicTable with pagination, selection, sorting and multiple record a
<EuiTableHeader>
<EuiTableHeaderCellCheckbox
key="_selection_column_h"
width="24px"
>
<EuiI18n
default="Select all rows"
Expand Down Expand Up @@ -3219,7 +3212,6 @@ exports[`EuiBasicTable with pagination, selection, sorting, column renderer and
<EuiTableHeader>
<EuiTableHeaderCellCheckbox
key="_selection_column_h"
width="24px"
>
<EuiI18n
default="Select all rows"
Expand Down
2 changes: 1 addition & 1 deletion src/components/basic_table/basic_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@ export class EuiBasicTable<T = any> extends Component<

if (selection) {
headers.push(
<EuiTableHeaderCellCheckbox key="_selection_column_h" width="24px">
<EuiTableHeaderCellCheckbox key="_selection_column_h">
{this.renderSelectAll(false)}
</EuiTableHeaderCellCheckbox>
);
Expand Down