Fix EuiCodeBlock padding for scrollbar #2727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40ac201 to
5359411
Compare
snide
approved these changes
Jan 2, 2020
| @@ -64,6 +60,8 @@ | |||
| font-size: $euiFontSize; | |||
| } | |||
|
|
|||
| $controlsPadding: $euiSizeL + $euiSizeXS; | |||
There was a problem hiding this comment.
Maybe put this higher in the document if you don't want to make a vars file?
There was a problem hiding this comment.
I not only didn't want to make a vars file but it really isn't necessary to be global (accessible outside of this selector). I'll just add a comment above it so that it stands out while moving through the nested selectors.
There was a problem hiding this comment.
Yep. Whenever I see a var I don't recognize I normally go through this order in assumptions of where it might is.
- /component/_variables.scss
- Top of .euiComponent, scoped within that component.
Just felt a little lonely there in the middle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression that was introduced when adjusting the position of the EuiCodeBlock control buttons
Before
After
Checklist
[ ] Check against all themes for compatability in both light and dark modes[ ] Props have proper autodocs[ ] Added documentation examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes