Skip to content

Commit

Permalink
[EuiTour] Style and a11y fixes (#5225)
Browse files Browse the repository at this point in the history
* [EuiTour] Made `subtitle` optional and fixed footer background
* [Breaking] Removes boolean as an option for `minWidth`
  And instead maps directly to `CSSProperties[‘minWidth’]` and applies it directly to `panelStyle`.
  Also adds `maxWidth` option.
* Better tests and switching to `h2` when no `subtitle`
  • Loading branch information
cchaos authored Sep 30, 2021
1 parent 9a5b78d commit e1a74cc
Show file tree
Hide file tree
Showing 6 changed files with 489 additions and 55 deletions.
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
## [`master`](https://github.com/elastic/eui/tree/master)

No public interface changes since `38.2.0`.
- Added `maxWidth` prop to `EuiTour`, made `subtitle` optional, and fixed heading levels and footer background ([#5225](https://github.com/elastic/eui/pull/5225))

**Breaking changes**

- Removed `boolean` from `EuiTour`'s `minWidth` type ([#5225](https://github.com/elastic/eui/pull/5225))

## [`38.2.0`](https://github.com/elastic/eui/tree/v38.2.0)

Expand Down
2 changes: 1 addition & 1 deletion src-docs/src/views/tour/step.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export default () => {
step={1}
stepsTotal={1}
title="Title of the current step"
subtitle="Title of the full tour"
subtitle="Title of the full tour (optional)"
anchorPosition="rightUp"
>
<EuiText>
Expand Down
Loading

0 comments on commit e1a74cc

Please sign in to comment.