Skip to content

Commit

Permalink
Rename .euiDataGridRowCell__expandButton to .euiDataGridRowCell__expa…
Browse files Browse the repository at this point in the history
…ndActions
  • Loading branch information
cee-chen committed Feb 2, 2022
1 parent 123f45b commit dc95fe9
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 8 deletions.
4 changes: 1 addition & 3 deletions src/components/datagrid/_data_grid_data_row.scss
Original file line number Diff line number Diff line change
Expand Up @@ -159,9 +159,7 @@
}

// Cell actions
// Could probably be more precisely named than '__expandButton', since there can be multiple actions/buttons
// TODO: Consider renaming this when working on https://github.com/elastic/eui/issues/5132
.euiDataGridRowCell__expandButton {
.euiDataGridRowCell__expandActions {
display: flex;
}
@include euiDataGridRowCellActions($definedHeight: false) {
Expand Down
4 changes: 2 additions & 2 deletions src/components/datagrid/_mixins.scss
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,12 @@ $euiDataGridStyles: (
@if $definedHeight {
// Defined heights are cells with row heights of auto, lineCount, or a static height
// that set the __contentByHeight class
.euiDataGridRowCell__contentByHeight + .euiDataGridRowCell__expandButton {
.euiDataGridRowCell__contentByHeight + .euiDataGridRowCell__expandActions {
@content;
}
} @else {
// Otherwise, an undefined height (single flex row) will set __expandContent
.euiDataGridRowCell__expandContent + .euiDataGridRowCell__expandButton {
.euiDataGridRowCell__expandContent + .euiDataGridRowCell__expandActions {
@content;
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/components/datagrid/body/data_grid_cell_actions.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ describe('EuiDataGridCellActions', () => {

expect(component).toMatchInlineSnapshot(`
<div
className="euiDataGridRowCell__expandButton"
className="euiDataGridRowCell__expandActions"
>
<EuiI18n
default="Click or hit enter to interact with cell content"
Expand Down Expand Up @@ -65,7 +65,7 @@ describe('EuiDataGridCellActions', () => {

expect(component).toMatchInlineSnapshot(`
<div
className="euiDataGridRowCell__expandButton"
className="euiDataGridRowCell__expandActions"
>
<Component
Component={[Function]}
Expand Down
2 changes: 1 addition & 1 deletion src/components/datagrid/body/data_grid_cell_actions.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export const EuiDataGridCellActions = ({
const buttonIconClasses = classNames('euiDataGridRowCell__expandButtonIcon', {
'euiDataGridRowCell__expandButtonIcon-isActive': popoverIsOpen,
});
const buttonClasses = classNames('euiDataGridRowCell__expandButton', {
const buttonClasses = classNames('euiDataGridRowCell__expandActions', {
'euiDataGridRowCell__expandButton-isActive': popoverIsOpen,
});
const expandButton = (
Expand Down

0 comments on commit dc95fe9

Please sign in to comment.