EuiComboBox prevent form submission (#2642)

* preventDefault * CL
elastic · Dec 12, 2019 · a05b1e7 · a05b1e7
1 parent ee5af7e
commit a05b1e7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 - Improved `EuiDataGrid` update performance ([#2638](https://github.com/elastic/eui/pull/2638))
 - Fixed `EuiDroppable` not accepting multiple children when using TypeScript ([#2634](https://github.com/elastic/eui/pull/2634))
+- Fixed `EuiComboBox` from submitting parent `form` element when selecting options via `Enter` key ([#2642](https://github.com/elastic/eui/pull/2642)) 
 
 ## [`17.1.2`](https://github.com/elastic/eui/tree/v17.1.2)
 

diff --git a/src/components/combo_box/combo_box.js b/src/components/combo_box/combo_box.js
@@ -387,6 +387,7 @@ export class EuiComboBox extends Component {
         break;
 
       case comboBoxKeyCodes.ENTER:
+        e.preventDefault();
         e.stopPropagation();
         if (this.hasActiveOption()) {
           this.onAddOption(