Skip to content

Commit

Permalink
Fix disabled hiding
Browse files Browse the repository at this point in the history
The `hidden` attribute sadly gets overridden by the new `display: flex`, so we need to restore the `:disabled { display: none }` selector
  • Loading branch information
cee-chen committed Aug 15, 2023
1 parent 78e57b8 commit 998cd84
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
4 changes: 4 additions & 0 deletions src/components/resizable_container/resizable_button.styles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ export const euiResizableButtonStyles = (euiThemeContext: UseEuiTheme) => {
justify-content: center;
gap: ${mathWithUnits(grabHandleHeight, (x) => x * 2)};
&:disabled {
display: none;
}
/* 1 */
&:hover,
&:focus {
Expand Down
1 change: 0 additions & 1 deletion src/components/resizable_container/resizable_button.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ export const EuiResizableButton: FunctionComponent<EuiResizableButtonProps> = ({
onFocus={() => onFocus?.(resizerId)}
onBlur={onBlur}
disabled={isDisabled}
hidden={isDisabled}
{...rest}
/>
)}
Expand Down

0 comments on commit 998cd84

Please sign in to comment.