[PR feedback] Remove isOpen prop from being

CHANGELOG.md

@@ -1,7 +1,7 @@
 ## [`master`](https://github.com/elastic/eui/tree/master)
 
 - Updated `EuiRangeLevel` `color` property to accept CSS color values ([#5171](https://github.com/elastic/eui/pull/5171))
-- Deprecated  `EuiSuperSelect`'s `popoverClassName`, `isOpen`, & `repositionOnScroll` props in favor of a single `popoverProps` configuration object ([#5214](https://github.com/elastic/eui/pull/5214))
+- Deprecated  `EuiSuperSelect`'s `popoverClassName` & `repositionOnScroll` props in favor of a single `popoverProps` configuration object ([#5214](https://github.com/elastic/eui/pull/5214))
 
 **Bug fixes**
 

src/components/form/super_select/__snapshots__/super_select.test.tsx.snap

@@ -726,7 +726,6 @@ exports[`EuiSuperSelect props renders popoverProps on the underlying EuiPopover
   popoverProps={
     Object {
       "className": "goes-on-outermost-wrapper",
-      "isOpen": false,
       "panelClassName": "goes-on-popover-panel",
       "repositionOnScroll": true,
     }

src/components/form/super_select/super_select.test.tsx

@@ -172,7 +172,6 @@ describe('EuiSuperSelect', () => {
             className: 'goes-on-outermost-wrapper',
             panelClassName: 'goes-on-popover-panel',
             repositionOnScroll: true,
-            isOpen: false,
           }}
         />
       );

src/components/form/super_select/super_select.tsx

@@ -69,12 +69,20 @@ export type EuiSuperSelectProps<T extends string> = CommonProps &
     itemLayoutAlign?: EuiContextMenuItemLayoutAlignment;
 
     /**
-     * Props to pass to the underlying [EuiPopover](/#/layout/popover). Allows
-     * fine-grained control of the popover dropdown menu, including `isOpen` state,
+     * Controls whether the options are shown. Default: false
+     */
+    isOpen?: boolean;
+
+    /**
+     * Optional props to pass to the underlying [EuiPopover](/#/layout/popover).
+     *  Allows fine-grained control of the popover dropdown menu, including
      * `repositionOnScroll` for EuiSuperSelects used within scrollable containers,
      * and customizing popover panel styling.
+     *
+     * Does not accept a nested `popoverProps.isOpen` property - use the top level
+     * `isOpen` API instead.
      */
-    popoverProps?: Partial<CommonProps & EuiPopoverProps>;
+    popoverProps?: Partial<CommonProps & Omit<EuiPopoverProps, 'isOpen'>>;
 
     /**
      * Applied to the outermost wrapper (popover)
@@ -83,13 +91,6 @@ export type EuiSuperSelectProps<T extends string> = CommonProps &
      */
     popoverClassName?: string;
 
-    /**
-     * Controls whether the options are shown. Default: false
-     *
-     * **DEPRECATED: Use `popoverProps.isOpen` instead (will take precedence over this prop if set).**
-     */
-    isOpen?: boolean;
-
     /**
      * When `true`, the popover's position is re-calculated when the user
      * scrolls. When nesting an `EuiSuperSelect` in a scrollable container,
@@ -338,12 +339,12 @@ export class EuiSuperSelect<T extends string> extends Component<
 
     return (
       <EuiInputPopover
-        isOpen={isOpen || this.state.isPopoverOpen}
         closePopover={this.closePopover}
         panelPaddingSize="none"
         repositionOnScroll={repositionOnScroll}
         {...popoverProps}
         className={popoverClasses}
+        isOpen={isOpen || this.state.isPopoverOpen}
         input={button}
         fullWidth={fullWidth}
       >