Skip to content

Commit

Permalink
Add links to comment in skipped test
Browse files Browse the repository at this point in the history
  • Loading branch information
acstll committed Feb 27, 2025
1 parent bb61e92 commit 59bdf51
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions packages/eui/src/components/flyout/flyout.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -291,9 +291,14 @@ describe('EuiFlyout', () => {
);
});

// TODO investigate why this test is failing for React 17 and 16
// (could certainy be improved a bit also)
it.skip('includes EuiCollapsibleNav items in tab rotation, inside EuiHeaders shards, while behaving as expected relative to other flyouts', () => {
/**
* @todo this fails with React 18, but passes with previous versions
* Focus behaviour is different in React 18, depending on whether 1 or more flyouts are open
*
* @see https://github.com/elastic/eui/pull/8325#discussion_r1973266414
* @see https://github.com/elastic/eui/issues/8376
*/
it.skip('includes EuiCollapsibleNav items in tab rotation, inside EuiHeaders shards', () => {
cy.viewport(800, 600);
cy.mount(
<FlyoutWithHeader collapsibleNavVariant="default"> </FlyoutWithHeader>
Expand All @@ -314,8 +319,6 @@ describe('EuiFlyout', () => {
cy.realPress('Tab');
cy.focused().should('not.have.text', 'Link A');
cy.realPress('Tab');
cy.focused().should('not.have.text', 'Link A');
cy.realPress('Tab');
cy.focused().should(
'have.attr',
'data-test-subj',
Expand Down

0 comments on commit 59bdf51

Please sign in to comment.