Migrate to data tiers routing configures correct default for mounted indices #97936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreidan
commented
Jul 25, 2023
Comment on lines
-145
to
-160
| /** | ||
| * Returns true iff the given settings have a data tier setting configured | ||
| */ | ||
| public static boolean isExplicitDataTier(Settings settings) { | ||
| /* | ||
| * This method can be called before the o.e.n.NodeRoleSettings.NODE_ROLES_SETTING is | ||
| * initialized. We do not want to trigger initialization prematurely because that will bake | ||
| * the default roles before plugins have had a chance to register them. Therefore, | ||
| * to avoid initializing this setting prematurely, we avoid using the actual node roles | ||
| * setting instance here in favor of the string. | ||
| */ | ||
| if (settings.hasValue("node.roles")) { | ||
| return settings.getAsList("node.roles").stream().anyMatch(DataTier::validTierName); | ||
| } | ||
| return false; | ||
| } |
There was a problem hiding this comment.
This is an unused method
|
Hi @andreidan, I've created a changelog YAML for you. |
|
Pinging @elastic/es-data-management (Team:Data Management) |
dakrone
approved these changes
Jul 25, 2023
💔 Backport failed
You can use sqren/backport to manually backport by running |
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
Jul 26, 2023
…indices (elastic#97936) (cherry picked from commit 1f24b9d) Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
This was referenced Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the default tier preference configuration the
migrate to tier routing API sets for fully and partially mounted
indices when the index was not migrated using the requested
attribute name and it doesn't have any
_tier_preferencesetting configured.
Fixes #97898