-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the Panama Vector module #96453
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3e05d35
just turn it on and see what breaks
ChrisHegarty 99d3426
switch based on a property.
ChrisHegarty af0dd46
Update docs/changelog/96453.yaml
ChrisHegarty eae28f4
use jvm.options
ChrisHegarty d33194d
Merge remote-tracking branch 'origin/enable_vector_module' into enabl…
ChrisHegarty 754e675
update change log
ChrisHegarty 3239e33
filter out incubator module warning.
ChrisHegarty b1007eb
Update docs/changelog/96453.yaml
ChrisHegarty 2bdc95a
suppress warning if disabled
ChrisHegarty 40440cc
Merge remote-tracking branch 'origin/enable_vector_module' into enabl…
ChrisHegarty 2d1300a
changelog
ChrisHegarty File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
pr: 96453 | ||
summary: Leverage SIMD hardware instructions in Vector Search | ||
area: Vector Search | ||
type: enhancement | ||
issues: [96370] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -269,8 +269,9 @@ public FileVisitResult visitFile(final Path file, final BasicFileAttributes attr | |
LogManager.getLogger("stderr"), | ||
Level.WARN, | ||
// MMapDirectory messages come from Lucene, suggesting to users as a warning that they should enable preview features in | ||
// the JDK | ||
List.of("MMapDirectory") | ||
// the JDK. Vector logs come from Lucene too, but only if the used explicitly disables the Vector API - no point warning | ||
// in this case. | ||
List.of("MMapDirectory", "VectorUtilProvider", "WARNING: Java vector incubator module is not readable") | ||
), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This suppresses the two line warning from Lucene, if one was to disable the Vector API (by editing jvm.options).
|
||
false, | ||
StandardCharsets.UTF_8 | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can this be moved to the top of the class and made
private static final
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, only seen this after merging. I'll move this as a follow-up.