[ILM] Fix the migrate to tiers service and migrate action tiers configuration #95934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The migrate action (although no allowed in the frozen phase) would seem to convert `frozen` to `data_frozen,data_cold,data_warm,data_hot` tier configuration. As the migrate action is not allowed in the frozen phase this would never happen, however the code is confusing as it seems like it could. The migrate to data tiers routing service shared the code that converted `frozen` to `data_frozen,data_cold,data_warm,data_hot` if it would encounter an index without any `_tier_preference` setting allocated on a node with the `data_frozen` role (again a seemingly impossible situaion) As part of elastic#84758 we have seen frozen indices with the `data_frozen,data_cold,data_warm,data_hot` tier preference however we could never reproduce it.
|
Documentation preview: |
|
Hi @andreidan, I've created a changelog YAML for you. |
|
Pinging @elastic/es-data-management (Team:Data Management) |
andreidan
commented
May 9, 2023
| @@ -148,7 +148,7 @@ public void testMigrateIlmPolicyForIndexWithoutILMMetadata() { | |||
| assertThat(migratedColdAllocateAction.getRequire().size(), is(0)); | |||
| } | |||
|
|
|||
| public void testMigrateIlmPolicyFOrPhaseWithDeactivatedMigrateAction() { | |||
| public void testMigrateIlmPolicyForPhaseWithDeactivatedMigrateAction() { | |||
gmarouli
approved these changes
May 9, 2023
|
@elasticmachine update branch |
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
May 9, 2023
…guration (elastic#95934) The migrate action (although no allowed in the frozen phase) would seem to convert `frozen` to `data_frozen,data_cold,data_warm,data_hot` tier configuration. As the migrate action is not allowed in the frozen phase this would never happen, however the code is confusing as it seems like it could. The migrate to data tiers routing service shared the code used by the `migrate` action that converted `frozen` to `data_frozen,data_cold,data_warm,data_hot` if it would encounter an index without any `_tier_preference` setting but with a custom node attribute configured to `frozen` e.g. `include.data: frozen` As part of elastic#84758 we have seen frozen indices with the `data_frozen,data_cold,data_warm,data_hot` tier preference however we could never reproduce it. Relates to elastic#84758
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
May 9, 2023
…guration (elastic#95934) The migrate action (although no allowed in the frozen phase) would seem to convert `frozen` to `data_frozen,data_cold,data_warm,data_hot` tier configuration. As the migrate action is not allowed in the frozen phase this would never happen, however the code is confusing as it seems like it could. The migrate to data tiers routing service shared the code used by the `migrate` action that converted `frozen` to `data_frozen,data_cold,data_warm,data_hot` if it would encounter an index without any `_tier_preference` setting but with a custom node attribute configured to `frozen` e.g. `include.data: frozen` As part of elastic#84758 we have seen frozen indices with the `data_frozen,data_cold,data_warm,data_hot` tier preference however we could never reproduce it. Relates to elastic#84758
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 9, 2023
…guration (#95934) (#95965) The migrate action (although no allowed in the frozen phase) would seem to convert `frozen` to `data_frozen,data_cold,data_warm,data_hot` tier configuration. As the migrate action is not allowed in the frozen phase this would never happen, however the code is confusing as it seems like it could. The migrate to data tiers routing service shared the code used by the `migrate` action that converted `frozen` to `data_frozen,data_cold,data_warm,data_hot` if it would encounter an index without any `_tier_preference` setting but with a custom node attribute configured to `frozen` e.g. `include.data: frozen` As part of #84758 we have seen frozen indices with the `data_frozen,data_cold,data_warm,data_hot` tier preference however we could never reproduce it. Relates to #84758
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 9, 2023
…guration (#95934) (#95966) The migrate action (although no allowed in the frozen phase) would seem to convert `frozen` to `data_frozen,data_cold,data_warm,data_hot` tier configuration. As the migrate action is not allowed in the frozen phase this would never happen, however the code is confusing as it seems like it could. The migrate to data tiers routing service shared the code used by the `migrate` action that converted `frozen` to `data_frozen,data_cold,data_warm,data_hot` if it would encounter an index without any `_tier_preference` setting but with a custom node attribute configured to `frozen` e.g. `include.data: frozen` As part of #84758 we have seen frozen indices with the `data_frozen,data_cold,data_warm,data_hot` tier preference however we could never reproduce it. Relates to #84758
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The migrate action (although no allowed in the frozen phase) would seem to convert
frozentodata_frozen,data_cold,data_warm,data_hottier configuration. As the migrate action is not allowed in the frozen phase this would never happen, however the code is confusing as it seems like it could.The migrate to data tiers routing service shared the code used by the
migrateaction that convertedfrozentodata_frozen,data_cold,data_warm,data_hotif it would encounter an index without any_tier_preferencesettingbut with a custom node attribute configured to
frozene.g.include.data: frozenAs part of #84758 we have seen frozen indices with the
data_frozen,data_cold,data_warm,data_hottier preference however we could never reproduce it.Relates to #84758