Add tests for multi_match phrase prefix query across multiple fields #95772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds unit test coverage for a bug that was recently found in Lucene. We would have caught it earlier if we were testing the underlying lucene query being generated. Closes elastic#95738
184799f to
984bb73
Compare
|
Pinging @elastic/es-search (Team:Search) |
|
The additional unit test will fail until we have upgraded to a Lucene version that fixes the bug upstream. |
romseygeek
approved these changes
May 10, 2023
server/src/test/java/org/elasticsearch/index/query/MultiMatchQueryBuilderTests.java
Show resolved
Hide resolved
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
May 10, 2023
…lastic#95772) This adds unit test coverage for a bug that was recently found in Lucene. We would have caught it earlier if we were testing the underlying lucene query being generated. Closes elastic#95738
💚 Backport successful
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds unit test coverage for a bug that was recently found in Lucene (see apache/lucene#12260). We would have caught it earlier if we were testing the underlying lucene query being generated.
Closes #95738