-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap profiling indices at startup #95666
Bootstrap profiling indices at startup #95666
Conversation
With this commit we bootstrap all indices and related structures that are required for Elastic Universal Profiling.
This is in preparation of setting up a K/V index scheme that allows the profiling solution to use the out of the box implementation of ILM in Elasticsearch (related to #85273). What's missing?
Both will be tackled in follow-up PRs. |
@elasticmachine merge upstream |
I am a bit uncertain which team would be most appropriate to look at this. I drew inspiration from #57629 when applying labels. Please feel free to relabel if required. |
Pinging @elastic/es-data-management (Team:Data Management) |
Hi @danielmitterdorfer, I've created a changelog YAML for you. |
@elasticmachine merge upstream |
There was an unrelated test failure. I raised #96000. |
@elasticmachine run elasticsearch-ci/part-2 |
I'm gonna look separately into |
...ck/plugin/core/src/main/resources/org/elasticsearch/xpack/profiler/ilm-policy/profiling.json
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,39 @@ | |||
{ | |||
"phases": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this policy reflecting the current set-up? If not, what is the rational behind the warm tier and the shrink action? Are they necessary or do they add enough value, for example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this PR I've basically only ported the existing policy as it is defined in https://github.com/elastic/kibana/blob/main/x-pack/plugins/profiling/server/lib/setup/steps/ilm_profiling.json but - as discussed offline - I agree that not everything in there makes sense. I'll address this later in a separate PR.
...ck/plugin/core/src/main/resources/org/elasticsearch/xpack/profiler/ilm-policy/profiling.json
Outdated
Show resolved
Hide resolved
...rofiler/src/internalClusterTest/java/org/elasticsearch/xpack/profiler/ProfilingTestCase.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @danielmitterdorfer thank you for breaking it into steps :). A few minor comments, that's all
...ck/plugin/profiler/src/main/java/org/elasticsearch/xpack/profiler/ProfilingIndexManager.java
Outdated
Show resolved
Hide resolved
...ck/plugin/profiler/src/main/java/org/elasticsearch/xpack/profiler/ProfilingIndexManager.java
Outdated
Show resolved
Hide resolved
...ck/plugin/profiler/src/main/java/org/elasticsearch/xpack/profiler/ProfilingIndexManager.java
Show resolved
Hide resolved
.../profiler/src/main/java/org/elasticsearch/xpack/profiler/ProfilingIndexTemplateRegistry.java
Outdated
Show resolved
Hide resolved
Thank you very much for the review @gmarouli! |
With this commit we bootstrap all indices and related structures that are required for Elastic Universal Profiling.