Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap profiling indices at startup #95666

Merged

Conversation

danielmitterdorfer
Copy link
Member

With this commit we bootstrap all indices and related structures that are required for Elastic Universal Profiling.

With this commit we bootstrap all indices and related structures that
are required for Elastic Universal Profiling.
@danielmitterdorfer
Copy link
Member Author

danielmitterdorfer commented Apr 28, 2023

This is in preparation of setting up a K/V index scheme that allows the profiling solution to use the out of the box implementation of ILM in Elasticsearch (related to #85273). What's missing?

  • Support for versioning upgrades of indices
  • Implementation of an index scheme for K/V indices that allows to use an ILM policy for these indices as well

Both will be tackled in follow-up PRs.

@danielmitterdorfer
Copy link
Member Author

@elasticmachine merge upstream

@danielmitterdorfer danielmitterdorfer added the :Data Management/Indices APIs APIs to create and manage indices and templates label May 5, 2023
@danielmitterdorfer
Copy link
Member Author

I am a bit uncertain which team would be most appropriate to look at this. I drew inspiration from #57629 when applying labels. Please feel free to relabel if required.

@danielmitterdorfer danielmitterdorfer marked this pull request as ready for review May 5, 2023 07:30
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label May 5, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine
Copy link
Collaborator

Hi @danielmitterdorfer, I've created a changelog YAML for you.

@danielmitterdorfer
Copy link
Member Author

@elasticmachine merge upstream

@danielmitterdorfer
Copy link
Member Author

There was an unrelated test failure. I raised #96000.

@danielmitterdorfer
Copy link
Member Author

@elasticmachine run elasticsearch-ci/part-2

@danielmitterdorfer
Copy link
Member Author

I'm gonna look separately into TransformUsageIT#testUsage() but despite that the PR is ready for review now.

@danielmitterdorfer danielmitterdorfer marked this pull request as ready for review May 10, 2023 16:08
@danielmitterdorfer
Copy link
Member Author

I've pushed a preliminary fix for the test failure here (to unblock progress on the PR) and have raised #96015 separately. I'll incorporate #96015 once it's merged to main.

@gmarouli gmarouli self-requested a review May 16, 2023 08:39
@@ -0,0 +1,39 @@
{
"phases": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this policy reflecting the current set-up? If not, what is the rational behind the warm tier and the shrink action? Are they necessary or do they add enough value, for example?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this PR I've basically only ported the existing policy as it is defined in https://github.com/elastic/kibana/blob/main/x-pack/plugins/profiling/server/lib/setup/steps/ilm_profiling.json but - as discussed offline - I agree that not everything in there makes sense. I'll address this later in a separate PR.

Copy link
Contributor

@gmarouli gmarouli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @danielmitterdorfer thank you for breaking it into steps :). A few minor comments, that's all

@danielmitterdorfer
Copy link
Member Author

Thank you very much for the review @gmarouli!

@danielmitterdorfer danielmitterdorfer merged commit 3aed349 into elastic:main May 16, 2023
@danielmitterdorfer danielmitterdorfer deleted the profiling-idx-bootstrap branch May 16, 2023 14:56
@danielmitterdorfer danielmitterdorfer restored the profiling-idx-bootstrap branch May 16, 2023 15:05
@danielmitterdorfer danielmitterdorfer deleted the profiling-idx-bootstrap branch May 16, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >enhancement Team:Data Management Meta label for data/management team v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants