-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geo_grid ingest processor docs #93507
Geo_grid ingest processor docs #93507
Conversation
Documentation preview: |
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Pinging @elastic/es-docs (Team:Docs) |
Adds docs for elastic#93370
247d36e
to
fd17de8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a docs perspective. I've left some minor suggestions to avoid the words "we" and "above".
| `non_children_field` | no | - | If specified and intersecting non-child tiles exist, save their addresses to this field as an array of strings. | ||
| `precision_field` | no | - | If specified, save the tile precision (zoom) as an integer to this field. | ||
| `ignore_missing` | no | - | If `true` and `field` does not exist, the processor quietly exits without modifying the document. | ||
| `target_format` | no | "GEOJSON" | Which format to save the generated polygon in. Either `WKT` or `GeoJSON`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming this is case-insensitive, but maybe it would be good to be consistent between "GEOJSON" and GeoJSON
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nit: Could you change the title of the PR from Geo_tile to Geo_grid?
Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
Co-authored-by: Abdon Pijpelink <abdon.pijpelink@elastic.co>
…ner/elasticsearch into geotile_ingest_processor_docs
Docs for #93370
Which satisfies the requests in #92473