Fix ByteArrayIndexInput with nonzero offset #93205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We introduced a bug in elastic#79885 by not accounting for cases where there's a nonzero offset in the underlying byte array. Unfortunately `ESIndexInputTestCase` didn't cover these code paths. This commit extends the test coverage and fixes the bug.
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
|
Pinging @elastic/es-distributed (Team:Distributed) |
iverase
approved these changes
Jan 24, 2023
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 24, 2023
We introduced a bug in elastic#79885 by not accounting for cases where there's a nonzero offset in the underlying byte array. Unfortunately `ESIndexInputTestCase` didn't cover these code paths. This commit extends the test coverage and fixes the bug.
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 24, 2023
We introduced a bug in #79885 by not accounting for cases where there's a nonzero offset in the underlying byte array. Unfortunately `ESIndexInputTestCase` didn't cover these code paths. This commit extends the test coverage and fixes the bug.
| // Read by one byte at a time | ||
| output[readPos++] = indexInput.readByte(); | ||
| final var readStrategy = randomFrom(2, 6); | ||
| switch (readStrategy) { |
There was a problem hiding this comment.
Above looks suspicious. Should it be randomIntBetween(0, 9)?
There was a problem hiding this comment.
There was a problem hiding this comment.
and #93227 fixes this in 8.6 too
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 25, 2023
In elastic#93205 we fixed a bug in `ByteArrayIndexInput` but accidentally reduced the coverage of the test suite with a supposedly-temporary change for debugging purposes. This commit brings the test suite back up to full strength again. This was fixed in `main` by elastic#93208, but most of that change is not for backporting.
DaveCTurner
added a commit
that referenced
this pull request
Jan 25, 2023
In #93205 we fixed a bug in `ByteArrayIndexInput` but accidentally reduced the coverage of the test suite with a supposedly-temporary change for debugging purposes. This commit brings the test suite back up to full strength again. This was fixed in `main` by #93208, but most of that change is not for backporting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced a bug in #79885 by not accounting for cases where there's a nonzero offset in the underlying byte array. Unfortunately
ESIndexInputTestCasedidn't cover these code paths. This commit extends the test coverage and fixes the bug.