Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[H3] Minor optimization in creating Vec2d objects #93166

Merged
merged 4 commits into from
Jan 24, 2023

Conversation

iverase
Copy link
Contributor

@iverase iverase commented Jan 23, 2023

This PR introduces the method CoordIJK#ijkToGeo that avoids creating a Vec2d object whenever we want to find the LatLng related to the CoordIJK.

@iverase iverase added >non-issue :Analytics/Geo Indexing, search aggregations of geo points and shapes v8.7.0 labels Jan 23, 2023
@iverase iverase requested a review from craigtaverner January 23, 2023 15:08
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jan 23, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

Copy link
Contributor

@craigtaverner craigtaverner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iverase iverase merged commit f49b520 into elastic:main Jan 24, 2023
@iverase iverase deleted the ijkToGeo branch January 24, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants