Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ActionListener#assertOnce #93159

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Add ActionListener#assertOnce #93159

merged 2 commits into from
Jan 24, 2023

Conversation

DaveCTurner
Copy link
Contributor

Alternative approach to #93143, avoiding adding overhead in production.

@DaveCTurner
Add ActionListener#assertOnce
58a2806 
Alternative approach to elastic#93143, avoiding adding overhead in production.
@DaveCTurner DaveCTurner added >non-issue :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. v8.7.0 labels Jan 23, 2023
@DaveCTurner DaveCTurner requested a review from tlrx January 23, 2023 14:06
@elasticsearchmachine elasticsearchmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Jan 23, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@DaveCTurner
Copy link
Contributor Author

Just a thought I had over lunch, not really very different but thought I'd share anyway.

tlrx
tlrx approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Actually I've done something like this in the Delegating class but somehow reverted it when moving the assertion lower.

@DaveCTurner
Copy link
Contributor Author

@elasticmachine update branch

@DaveCTurner DaveCTurner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jan 24, 2023
@elasticsearchmachine elasticsearchmachine merged commit b97eafa into elastic:main Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlrx tlrx tlrx approved these changes

Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >non-issue Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DaveCTurner @elasticsearchmachine @tlrx @elasticmachine